[VOTE] jsond View as Markdown

Hi

What’s the status of the Preserve Fractional Part RFC with relation to the
jsond extension?

The preserve fractional part RFC has been accepted as a non-default option.
It's also non-default option in jsond and the proposed patch.

You probably ask me because I wanted to make it default. :) However I don't
want to change it if the flag is already in. It would make mess in the
default flag (option) value which would be changed from 0 and complicate
the current way of enabling and disabling flags - people would have look to
the doc to see what the default is and then OR this option with their
settings if they wanted to keep the default and add a new flag - that would
be just wrong IMHO... It means that I don't have any plans to propose such
thing. And even if I had, it wouldn't be part of this RFC. ;)

Cheers

Jakub

Andrea,

I did a PR to Jakub's branch with changes of preserve fractional part rfc
after it was approved. His branch has the same implementation that was
merged into 5.6, but adapted to master.

Also, as he mentioned, the same behavior, options disabled by default.

Juan Baso

Hi Jakub,

What’s the status of the Preserve Fractional Part RFC with relation to the
jsond extension?

I’d like to know that before voting.

Thanks.

Hi All!

Voting on jsond is now open:

https://wiki.php.net/rfc/jsond

It's a simple Yes/No vote whether jsond should replace the current json
extension in PHP 7.

Cheers

Jakub

--
Andrea Faulds
http://ajf.me/

On Sun, Jan 25, 2015 at 6:27 PM, Stanislav Malyshev smalyshev@gmail.com
wrote:

Please do not forget to add all BC-breaking changes in UPGRADING
(currently not part of the patch).

Just added in
https://github.com/bukka/php-src/commit/22394b79423b6c4eab3d43e246e03fc3feedfff5
. ;)

Thanks

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 25/01/2015 18:29, Jakub Zelenka a écrit :

Hi All!

Voting on jsond is now open:

https://wiki.php.net/rfc/jsond

It's a simple Yes/No vote whether jsond should replace the current
json extension in PHP 7.

Minor notice:

• • php 5.x use version 1.2.x
• • pecl/jsonc and pecl/jsond (for 5.x) use version 1.3.x

I think it will make sense to bump release to 1.4.0, so this can be
test at runtime.

Remi.

It makes sense.

I was just about to bump it when I realized that there is still outdated
package.json . Is there any reason why it should be kept? It's very
outdated and looks to me that it was just copied when the original
extension got in.

It's also a bit inconsistent for other extensions (some have package.json
but most don't) so I would like to check before removing it... Is there any
use for packages.json in the core ext?

Voting on jsond is now open:

https://wiki.php.net/rfc/jsond

It's a simple Yes/No vote whether jsond should replace the current json
extension in PHP 7.

Before I vote I want to double-check something that I didn't find
explicitly mentioned in the RFC and at a quick glance in the
implementation I couldn't tell either: does this support any
non-standard features such as comments? I am hoping that the lack of
it being mentioned means it isn't there, but I want to double-check
first.

No extra features ;). It's the same as the old one except the BC change
mentioned in the RFC

Cheers

Jakub