PowerPC64 patchs - Externals

11 years ago by Gustavo Frederico Temple Pedrosa — view source — reply

unread

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

Anyone can review them, please?

Remi, can you do a quick test build, please?

Thanks a lot, all!

11 years ago by Dmitry Stogov — view source — reply

unread

I see no problems with these patches.
If all tests on PPC are passed, then they should be accepted.
The patches won't affect other architectures.

Anybody tested?

Thanks. Dmitry.

On Thu, Nov 27, 2014 at 3:39 PM, Gustavo Frederico Temple Pedrosa <
gustavo.pedrosa@eldorado.org.br> wrote:

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

Anyone can review them, please?

Remi, can you do a quick test build, please?

Thanks a lot, all!

11 years ago by Remi Collet — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 28/11/2014 10:10, Dmitry Stogov a écrit :

I see no problems with these patches. If all tests on PPC are
passed, then they should be accepted. The patches won't affect
other architectures.

Anybody tested?

I should be able to run some scratch build next week

Remi.

Thanks. Dmitry.

On Thu, Nov 27, 2014 at 3:39 PM, Gustavo Frederico Temple Pedrosa
< gustavo.pedrosa@eldorado.org.br> wrote:

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

Anyone can review them, please?

Remi, can you do a quick test build, please?

Thanks a lot, all!

-- To
unsubscribe, visit: http://www.php.net/unsub.php

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR4YjQACgkQYUppBSnxahgW7wCeOw6Y/LhfahdsN+d+BrJWMZSG
F88AoL7wFCZipQLZP8GMb2FvMNI9V+P4
=3UO6
-----END PGP SIGNATURE

11 years ago by Stanislav Malyshev — view source — reply

unread

Hi!

I should be able to run some scratch build next week

That'd be great. I thought about merging them but since I don't have any
ppc64 hardware around I was not sure, but if you have some it'd be great.

Stas Malyshev
smalyshev@gmail.com

11 years ago by Remi Collet — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit :

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

I have run a build of master with each PR.

Comments added on all.

922 merged.

Notice: master on ppc64 seems in quite bad shape, we currently have
111 failed tests (with ./configure --disable-all).

I will try to keep the ppc64 machine to run a few more tests.

Remi.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA
AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9
=CkYT
-----END PGP SIGNATURE

11 years ago by Remi Collet — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 01/12/2014 11:09, Remi Collet a écrit :

Notice: master on ppc64 seems in quite bad shape, we currently
have 111 failed tests (with ./configure --disable-all).

82 fixed
29 to work on...

Remi.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR8iPcACgkQYUppBSnxahgh5wCeOHM+skY4oEP2rc85wlma7jJQ
tOoAoJEU9BVdQHkFmWsljB78Tud38K/L
=gtvF
-----END PGP SIGNATURE

11 years ago by Andrea Faulds — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 01/12/2014 11:09, Remi Collet a écrit :

Notice: master on ppc64 seems in quite bad shape, we currently
have 111 failed tests (with ./configure --disable-all).

82 fixed
29 to work on...

Remi.

Would you mind revealing which tests failed? This might be important to me with bigints.

Andrea Faulds
http://ajf.me/

11 years ago by Ferenc Kovacs — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 01/12/2014 11:09, Remi Collet a écrit :

Notice: master on ppc64 seems in quite bad shape, we currently
have 111 failed tests (with ./configure --disable-all).

82 fixed
29 to work on...

Remi.

Would you mind revealing which tests failed? This might be important to me
with bigints.

if anybody willing to help with the ppc64 test failures, but doesn't have
access to a ppc64 machine:
it is possible to run ppc64 virtual machines via qemu/kvm, I still have a
couple of issues running it on Mac, but it should be easier on linux, here
are some relevant links I've found:
https://gmplib.org/~tege/qemu.html
http://nathaniel.themccallums.org/2013/03/30/qemu-with-powerpc64-guests/
https://github.com/osuosl/packer-templates
http://ftp.osuosl.org/pub/osl/openpower/openstack/
https://github.com/adrahon/vagrant-kvm

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

11 years ago by Remi Collet — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 02/12/2014 11:11, Andrea Faulds a écrit :

Would you mind revealing which tests failed? This might be
important to me with bigints.

See my previous mail in this thread failed tests are attached, but
most are fixed (well, I haven't test any extension yet)

But see more recent "Test suite results on bigendian" mail
Only issue with new mm, Dmitry working on it
(seems like related to pagesize which is 64k; not 4k)

Remi.

-- Andrea Faulds http://ajf.me/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR9lZcACgkQYUppBSnxahgxOQCghp/rRuzeW8jffJTrNhKJ07jl
FlMAnRIdaPqxk2ZYBya4q52z0wLQRk26
=E7O4
-----END PGP SIGNATURE

11 years ago by Andrea Faulds — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 02/12/2014 11:11, Andrea Faulds a écrit :

Would you mind revealing which tests failed? This might be
important to me with bigints.

See my previous mail in this thread failed tests are attached, but
most are fixed (well, I haven't test any extension yet)

Ah, these aren’t the kind of tests which bigints would affect, luckily for me. ^^

Andrea Faulds
http://ajf.me/

11 years ago by Lior Kaplan — view source — reply

unread

Remi,

Any chance to have these fixes for 5.5/5.6 as well?

Kaplan

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit :

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

I have run a build of master with each PR.

Comments added on all.

922 merged.

Notice: master on ppc64 seems in quite bad shape, we currently have
111 failed tests (with ./configure --disable-all).

I will try to keep the ppc64 machine to run a few more tests.

Remi.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA
AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9
=CkYT
-----END PGP SIGNATURE

11 years ago by Remi Collet — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 02/12/2014 11:01, Lior Kaplan a écrit :

Remi,

Any chance to have these fixes for 5.5/5.6 as well?

All failed tests (and fix) are master only
related to move to size_t and new mm.

The only 5.6 issue (pack/unpack) have be fixed in 5.6+

Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEUEARECAAYFAlR9lMcACgkQYUppBSnxahjsowCfWuiHd3m0TcQkHj+Qj0oXOO+k
2VsAmMGUit06VCEX/EC44tIlzTJ8U04=
=EGTp
-----END PGP SIGNATURE

11 years ago by Gustavo Frederico Temple Pedrosa — view source — reply

unread

Lior,

Remi performed the tests and I'm correcting now the errors.

The PR #737 was closed and the PR #922 was merged :)

Thanks.

From: Lior Kaplan [mailto:lior.k@zend.com]
Sent: terça-feira, 2 de dezembro de 2014 08:01
To: Remi Collet
Cc: Gustavo Frederico Temple Pedrosa; PHP Internals
Subject: Re: [PHP-DEV] Re: PowerPC64 patchs

Remi,

Any chance to have these fixes for 5.5/5.6 as well?

Kaplan

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit :

Hi, internals!

There are some PRs for supports of PowerPC64

https://github.com/php/php-src/pull/737
https://github.com/php/php-src/pull/919
https://github.com/php/php-src/pull/920
https://github.com/php/php-src/pull/921
https://github.com/php/php-src/pull/922

I have run a build of master with each PR.

Comments added on all.

922 merged.

Notice: master on ppc64 seems in quite bad shape, we currently have
111 failed tests (with ./configure --disable-all).

I will try to keep the ppc64 machine to run a few more tests.

Remi.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA
AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9
=CkYT
-----END PGP SIGNATURE

PowerPC64 patchs View as Markdown

That'd be great. I thought about merging them but since I don't have any ppc64 hardware around I was not sure, but if you have some it'd be great.

Would you mind revealing which tests failed? This might be important to me with bigints.

Ah, these aren’t the kind of tests which bigints would affect, luckily for me. ^^

That'd be great. I thought about merging them but since I don't have any
ppc64 hardware around I was not sure, but if you have some it'd be great.