Hi all,
The RFC https://wiki.php.net/rfc/session-lock-ini was accepted and the
patch for this was ready to merge, but it wasn't merged to 5.6 by mistake.
The patch is this.
https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-session-lock
(It's been a while and it has to be updated for current code)
I may update the patch and merge, but question is which branch should be,
5.6.3, 5.6.4, or master?
I need comments from RM.
Thank you.
--
Yasuo Ohgaki
yohgaki@ohgaki.net
2014.11.06. 7:10 ezt írta ("Yasuo Ohgaki" yohgaki@ohgaki.net):
Hi all,
The RFC https://wiki.php.net/rfc/session-lock-ini was accepted and the
patch for this was ready to merge, but it wasn't merged to 5.6 by mistake.The patch is this.
https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-session-lock
(It's been a while and it has to be updated for current code)I may update the patch and merge, but question is which branch should be,
5.6.3, 5.6.4, or master?I need comments from RM.
Thank you.--
Yasuo Ohgaki
yohgaki@ohgaki.net
As I mentioned in my mail yesterday, I would prefer delaying this for the
next minor/major version (and reverting the write short circuit from 5.6).
But putting that aside, I think it would make sense addressing the points
brought up by Andrej regarding this rfc.
Ps: and dont forget/ignore that originally only the read only/lazy write
parts were accepted, the other two proposals did not.
Hi Ferenc,
Ps: and dont forget/ignore that originally only the read only/lazy write
parts were accepted, the other two proposals did not.
I think the branch has only read only and lazy write parts. I'll double
check.
The branch seems to contain 2 feature requests. I'll commit them separately.
I have an personal request that would like to see the read only/lazy write
feature
for 5.6. However, since it modify module global, master may to the branch.
Feature requests must be in master.
I don't mind which branch would have this RFC.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net