Hi!
The first RC of the PHP 5.4.33 was just released and can be
downloaded from:
http://downloads.php.net/stas/
The Windows binaries are available at
http://windows.php.net/qa/
This release contains a number of bugfixes.
For the list of bugfixes that you can target in your
testing, please refer to the NEWS file:
https://github.com/php/php-src/blob/php-5.4.33RC1/NEWS
Please test it carefully, and report any bugs in the bug system.
Please note that PHP 5.4.33 is the last version of the PHP 5.4 branch
that is supposed to contain non-security bugfixes. Next versions would
be for security-related bugfixes. Thus, it is very important to test
this version thoroughly, as regressions in this version may be more
problematic to fix.
The release is planned in 2 weeks, September 18th, if no critical issues
will be discovered in the RC.
Regards,
Stas Malyshev
PHP 5.4 RM
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Running a test build of 5.4.33RC1.
Testing the fix for the SCRIPT_NAME issue
-
SetHandler Configuration
<FilesMatch .php$>
SetHandler "proxy:fcgi://127.0.0.1:9003"
</FilesMatch>
URL = /info.php/a/b?q=a
SCRIPT_NAME = /info.php
=> OK
-
ProxyPass Configuration
ProxyPass /proxy/ fcgi://127.0.0.1:9003//var/www/html/
URL = /proxy/info.php/a/b?q=a
SCRIPT_NAME = /proxy/info.php/a/b
=> Broken
IIUC, fix for #67606 is only for mod_fastcgi
Remi
P.S. same result with 5.6.0.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQJm/cACgkQYUppBSnxahgB3ACg1tLH4AMt3LB0/Zog9StErD2v
PRMAoIU6JsKeuRCkTOqw2ho0CeeLcHHE
=Ipit
-----END PGP SIGNATURE
ProxyPass Configuration
ProxyPass /proxy/ fcgi://127.0.0.1:9003//var/www/html/
URL = /proxy/info.php/a/b?q=a
SCRIPT_NAME = /proxy/info.php/a/b
=> Broken
This is bugging me too on my development machine where I'm stuck at
Apache 2.4.9 which doesn't yet have support for using SetHandler this
way.
Applying the patch fpm_main-script_name-v2.patch proposed on
https://bugs.php.net/bug.php?id=65641 fixes the issue for me.
This is happening for me with PHP 5.4, 5.5 and 5.6 (which are the ones
I tested).
Philip
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 05/09/2014 14:54, Philip Hofstetter a écrit :
Applying the patch fpm_main-script_name-v2.patch proposed on
https://bugs.php.net/bug.php?id=65641 fixes the issue for me.
This patch doesn't check for tflag, which seems usefull...
Another try attached.
Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQJtvsACgkQYUppBSnxahgSgACg4XwYbfGiw1Dygg1NboYwG3v8
lyEAnRV+ahyqt5RwyrT8sUXdoZ6KeS5h
=teMn
-----END PGP SIGNATURE
The fixes in that ticket were pretty risky as they very late in the game fiddled with strings. That was brittle should have been fixed earlier during request processing.
The new patch (https://bugs.php.net/patch-display.php?bug=65641&patch=Another_fix_for_mod_proxy_fcgi.patch&revision=1409922889) looks better, but doesn't account for cases where SCRIPT_NAME Is correct (not sure if that can be checked), and I don't understand why env_script_name is restored back to its original value after writing it to SCRIPT_NAME. At the very least, the comment in that if should say "this is for ProxyPass and SCRIPT_NAME being broken with index.php/foo";.
But that doesn't matter anyway, because ProxyPass is a bag of hurt for a million and one reasons. Rewrites are not applied, you can't check if the file exists et cetera.
People should simply use the SetHandler approach instead. If your version of Apache 2.4 doesn't have that yet, use https://gist.github.com/progandy/6ed4eeea60f6277c3e39
David
P.S.: if you also want to check if the .php file exists:
<FilesMatch .php$>
<If "-f %{REQUEST_FILENAME}"> # make sure the file exists so that if not, Apache will show its 404 page and not FPM
SetHandler "proxy:fcgi://127.0.0.1:9003"
</If>
</FilesMatch>
P.P.S.: as a reminder, if you want to use UDS:
<Proxy "unix:/tmp/php.sock|fcgi://php">
disablereuse off # any parameter in here will do so the proxy is registered during startup and can be referenced later as "fcgi://php"
</Proxy>
<FilesMatch .php$>
<If "-f %{REQUEST_FILENAME}">
SetHandler "proxy:fcgi://php"
</If>
</FilesMatch>
ProxyPass Configuration
ProxyPass /proxy/ fcgi://127.0.0.1:9003//var/www/html/
URL = /proxy/info.php/a/b?q=a
SCRIPT_NAME = /proxy/info.php/a/b
=> BrokenThis is bugging me too on my development machine where I'm stuck at
Apache 2.4.9 which doesn't yet have support for using SetHandler this
way.Applying the patch fpm_main-script_name-v2.patch proposed on
https://bugs.php.net/bug.php?id=65641 fixes the issue for me.This is happening for me with PHP 5.4, 5.5 and 5.6 (which are the ones
I tested).Philip
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 05/09/2014 15:52, David Zuelke a écrit :
People should simply use the SetHandler approach instead.
I agree, see https://bugzilla.redhat.com/1136290
But some people may want to use ProxyPass (ex, to redirect to another
server, with no PHP script installed locally).
Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQJ+MEACgkQYUppBSnxahj4XwCgigk0BodBw1hYjmqbF0sY2v/b
IVwAn2MPrRUmd7+I/w+CvxjU+aKvNoWa
=v5gN
-----END PGP SIGNATURE
Hi!
So what is the resolution for this? Should we roll back the fix,
implement the new one and have one more RC, do something else?
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
The fix is not broken. He's describing a different/additional issue. Things have always been shaky with ProxyPass (that's https://bugs.php.net/bug.php?id=65641) because it's a bag of hurt. That's the whole reason Apache now has SetHandler for proxies!
Hi!
So what is the resolution for this? Should we roll back the fix,
implement the new one and have one more RC, do something else?Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 09/09/2014 07:54, Stas Malyshev a écrit :
Hi!
So what is the resolution for this? Should we roll back the fix,
implement the new one and have one more RC, do something else?
Sorry, it seems I have miss your question :(
As David Zuelke said, this is another fix, so no regression.
The big issue I see, is the news entry:
. Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME variable
when using Apache). (David Zuelke)
And 65641 is not fixed.
Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQRTD0ACgkQYUppBSnxahjavgCgw7GW0MYikE9Q26On64rxo1GO
cdcAn0mDqaWclVT2caJ/2abz950zZFRY
=7cnp
-----END PGP SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 11/09/2014 09:16, Remi Collet a écrit :
Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I see,
is the news entry:. Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME
variable when using Apache). (David Zuelke)
Should probably be:
. Fixed #67606 (FPM with mod_fastcgi/apache2.4 is broken)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQRTR8ACgkQYUppBSnxahgRhACgmrK+k8SmZGfkwXTfuW6LMXN2
KBQAn0HjOgBzeWMOGXtS2J5tCQxuQ+kA
=xzzJ
-----END PGP SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 11/09/2014 09:19, Remi Collet a écrit :
Le 11/09/2014 09:16, Remi Collet a écrit :
Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I
see, is the news entry:. Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME
variable when using Apache). (David Zuelke)Should probably be:
. Fixed #67606 (FPM with mod_fastcgi/apache2.4 is broken)
I fixed the NEW entry in
5.4: 2775dc2b443fc8abc3ae0a659c3a8a800ab90035
5.5: 6dc6daf7e33524531e429ea0ac8b2ecfd9325122
Can you please cherry-pick this in 5.4.33 / 5.5.17 before the release ?
I plan to apply the patch for 65641 later in 5.5+
so for 5.5.17, 5.6.2, as this one really need tests
and don't want to break anything else...
Remi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQWiUAACgkQYUppBSnxahiukACg6YuLevbuZQw7/LjWNCgmub+L
KzgAoOrZ8QUwjZZULKh68nCIxwQzgMOx
=UvXq
-----END PGP SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Le 11/09/2014 09:19, Remi Collet a écrit :
Le 11/09/2014 09:16, Remi Collet a écrit :
Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I
see, is the news entry:. Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME
variable when using Apache). (David Zuelke)Should probably be:
. Fixed #67606 (FPM with mod_fastcgi/apache2.4 is broken)
I fixed the NEW entry in
5.4: 2775dc2b443fc8abc3ae0a659c3a8a800ab90035
5.5: 6dc6daf7e33524531e429ea0ac8b2ecfd9325122Can you please cherry-pick this in 5.4.33 / 5.5.17 before the release ?
I plan to apply the patch for 65641 later in 5.5+
so for 5.5.17, 5.6.2, as this one really need tests
and don't want to break anything else...Remi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/iEYEARECAAYFAlQWiUAACgkQYUppBSnxahiukACg6YuLevbuZQw7/LjWNCgmub+L
KzgAoOrZ8QUwjZZULKh68nCIxwQzgMOx
=UvXq
-----END PGP SIGNATURE-------
We could have used the same NEWS entry from 5.6 I suppose:
. Fixed bug #67606 (revised fix 67541, broke mod_fastcgi BC). (David
Zuelke)
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 24/09/2014 09:33, Ferenc Kovacs a écrit :
We could have used the same NEWS entry from 5.6 I suppose: . Fixed
bug #67606 (revised fix 67541, broke mod_fastcgi BC). (David
Zuelke)
I fixed NEWS in 5.4 / 5.5 "before" the release (5.4.33 / 5.5.17)
In 5.6, there is no entry for 65641 (but one for 67541...)
5.6.1 have no FPM changes
5.6.2 will have the fix for #65641
But perhaps I have miss something..
Yes... these fcgi issues are a mess..
(and some are still open, perhaps duplicates)
Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlQifPsACgkQYUppBSnxahh8zwCfTRvoN7/NdzQycsaDxK5m+QWW
FQwAoPThXlv8Jn9n+g2gpfwCm4h94NTT
=/bGU
-----END PGP SIGNATURE
On Wed, Sep 24, 2014 at 10:12 AM, Remi Collet remi@fedoraproject.org
wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Le 24/09/2014 09:33, Ferenc Kovacs a écrit :
We could have used the same NEWS entry from 5.6 I suppose: . Fixed
bug #67606 (revised fix 67541, broke mod_fastcgi BC). (David
Zuelke)I fixed NEWS in 5.4 / 5.5 "before" the release (5.4.33 / 5.5.17)
In 5.6, there is no entry for 65641 (but one for 67541...)
oops, sorry, you are right, I was just mixing up those numbers in my head.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Le 05/09/2014 15:52, David Zuelke a écrit :
People should simply use the SetHandler approach instead.
I agree, see https://bugzilla.redhat.com/1136290
But some people may want to use ProxyPass (ex, to redirect to another
server, with no PHP script installed locally).
You can do that just fine with SetHandler; the FastCGI server doesn't have to be on the same box.
David