Bug 55700 fix - Externals

11 years ago by Chris Wright — view source — reply

unread

Good evening all

I've put together a patch for bug 55600 which can be seen here:
https://github.com/php/php-src/pull/779

The patch has been updated based on various feedback and afaict is now
ready to be merged. Does anyone have any more feedback on the
implementation?

If no-one has any objections to this, I would like to merge it into
5.6 and master.

Thanks, Chris

11 years ago by Michael Wallner — view source — reply

unread

Good evening all

I've put together a patch for bug 55600 which can be seen here:
https://github.com/php/php-src/pull/779

The patch has been updated based on various feedback and afaict is now
ready to be merged. Does anyone have any more feedback on the
implementation?

If no-one has any objections to this, I would like to merge it into
5.6 and master.

11 years ago by Lior Kaplan — view source — reply

unread

If no-one has any objections to this, I would like to merge it into
5.6 and master.

+1

Why not 5.5 ?

Kaplan

11 years ago by Chris Wright — view source — reply

unread

If no-one has any objections to this, I would like to merge it into
5.6 and master.

+1

Why not 5.5 ?

I... don't know. No reason it shouldn't go into 5.5 I guess, unless
anyone has an objection to this?

Kaplan

11 years ago by Michael Wallner — view source — reply

unread

If no-one has any objections to this, I would like to merge it into
5.6 and master.

+1

Why not 5.5 ?

I... don't know. No reason it shouldn't go into 5.5 I guess, unless
anyone has an objection to this?

5.5 is the current bug-fix only branch.

If no-one has any objections to this, I would like to merge it into
5.6 and master.

+1

Why not 5.5 ?

I... don't know. No reason it shouldn't go into 5.5 I guess, unless
anyone has an objection to this?

Kaplan

11 years ago by Chris Wright — view source — reply

unread

If no-one has any objections to this, I would like to merge it into
5.6 and master.

+1

Why not 5.5 ?

I... don't know. No reason it shouldn't go into 5.5 I guess, unless
anyone has an objection to this?

5.5 is the current bug-fix only branch.

I think this is broadly my reasoning for originally targeting 5.6 with
this, but actually the release process does not state that the
"current" and "previous" maintained release branches are any different
in this respect.

I'm fine with either option, just not sure what the accepted best
approach is here? Reading the release process again makes me think it
should either be >=5.5 or master only.

Thanks