Hi,
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails ignored,
so I I've changed it to git-pulls@lists.php.net:
http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.
ps: it can take some time for the change to propagate to the server.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails ignored,
so I I've changed it to git-pulls@lists.php.net:
http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.
Are you sure that’s the best idea? I think that redirecting it away from internals will make it useless. Few subscribe to git-pulls, and if people wanted to opt-in to notifications, they could just “Watch” the repo on GitHub themselves. The whole point of mailing the list automatically is to stop pull requests being neglected, as many people don’t mail internals when they make a pull request. By pointing it at internals, it would not distract from normal mail, not drown things out (there aren’t that many requests). It would, however, ensure such pull requests hopefully see more attention.
--
Andrea Faulds
http://ajf.me/
While I wholeheartedly agree with the sentiment of getting people to
pay attention to PRs, I don't think that filling this list with yet
more crud is the way to do it, not least because of the number of
people who read this list and don't have to power to do anything about
them.
I'd rather see some method of sending these only to people (for ex.)
with src karma, but doing this automatically (sending them to those
users' @php.net addresses might be an idea?).
I'd support some kind of reminder after, say, a month of inactivity
being sent to this list though.
My $0.02
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails ignored,
so I I've changed it to git-pulls@lists.php.net:
http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.Are you sure that’s the best idea? I think that redirecting it away from internals will make it useless. Few subscribe to git-pulls, and if people wanted to opt-in to notifications, they could just “Watch” the repo on GitHub themselves. The whole point of mailing the list automatically is to stop pull requests being neglected, as many people don’t mail internals when they make a pull request. By pointing it at internals, it would not distract from normal mail, not drown things out (there aren’t that many requests). It would, however, ensure such pull requests hopefully see more attention.
--
Andrea Faulds
http://ajf.me/
Hi
2014-06-11 20:52 GMT+02:00 Ferenc Kovacs tyra3l@gmail.com:
Hi,
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails ignored,
so I I've changed it to git-pulls@lists.php.net:
http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.
While I agree that it is just plain annoying to have git pulls coming
to internals, I subscribed to internals for discussions, not a list
that also spams me with pull requests.
What I suggest we do is to have a weekly cron that sends out an
overview (and possibly their status) of git pulls made, maybe send it
out friday so there is something for the weekend warriors to look at,
I think that would work better and work as a nice middle thing. I
could live with a weekly or so mail with pull requests, but I would be
annoyed with say a few daily.
--
regards,
Kalle Sommer Nielsen
kalle@php.net
What I suggest we do is to have a weekly cron that sends out an
overview (and possibly their status) of git pulls made, maybe send it
out friday so there is something for the weekend warriors to look at,
I think that would work better and work as a nice middle thing. I
could live with a weekly or so mail with pull requests, but I would be
annoyed with say a few daily.
A digest would indeed be good. How about one daily?
--
Andrea Faulds
http://ajf.me/
I'm subscribed to internals for the discussion as well as to learn about
new rfcs and pull requests. Are there really enough pull requests each day
to warrant calling this 'spam'?
Hi
2014-06-11 20:52 GMT+02:00 Ferenc Kovacs tyra3l@gmail.com:
Hi,
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails
ignored,
so I I've changed it to git-pulls@lists.php.net:http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.
While I agree that it is just plain annoying to have git pulls coming
to internals, I subscribed to internals for discussions, not a list
that also spams me with pull requests.What I suggest we do is to have a weekly cron that sends out an
overview (and possibly their status) of git pulls made, maybe send it
out friday so there is something for the weekend warriors to look at,
I think that would work better and work as a nice middle thing. I
could live with a weekly or so mail with pull requests, but I would be
annoyed with say a few daily.--
regards,Kalle Sommer Nielsen
kalle@php.net
Hi
2014-06-12 8:07 GMT+02:00 Rowan Lewis rl@nbsp.io:
I'm subscribed to internals for the discussion as well as to learn about new
rfcs and pull requests. Are there really enough pull requests each day to
warrant calling this 'spam'?
I can undertand from a core dev's standpoint that these fit on the
internals, but then one can argue what about all commits to ZE? Sure
they are internals and core related too? We cannot just clutch it all
together, and should allow people who WANTS to actively look at PRs to
subscribe to a list, and from how it sounds then there is a couple
here that wants that and wants it on internals, but like Derick, you
should be able to opt-in on it and opt-out as you please while still
being able to read internals discussions.
--
regards,
Kalle Sommer Nielsen
kalle@php.net
I can undertand from a core dev's standpoint that these fit on the
internals, but then one can argue what about all commits to ZE? Sure
they are internals and core related too? We cannot just clutch it all
together, and should allow people who WANTS to actively look at PRs to
subscribe to a list, and from how it sounds then there is a couple
here that wants that and wants it on internals, but like Derick, you
should be able to opt-in on it and opt-out as you please while still
being able to read internals discussions.
Should we move patch discussions out of internals altogether and leave it only for RFCs, then? Because patches are already proposed here, and pull requests are really just patch requests.
--
Andrea Faulds
http://ajf.me/
There were some vocal feedback about not spamming the list and/or not
letting the generic traffic of the internals@ making the PR mails ignored,
so I I've changed it to git-pulls@lists.php.net:
http://git.php.net/?p=web/master.git;a=commit;h=c5fe83adb08b64267d1a5c01a8f301b8cdce55b6
If you are interested in these mails, you should subscribe that list.
OK. Awesome!
cheers,
Derick
--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Posted with an email client that doesn't mangle email: alpine