You can view the Pull Request on github:
https://github.com/php/php-src/pull/693
Pull Request Description:
This should be a fairly cheap win to make pcntl_signal_dispatch() somewhat faster in the case there are no signals pending.
You can view the Pull Request on github:
https://github.com/php/php-src/pull/693
Why is this not going to git-pulls@ ? Please don't make new PRs drown in
the noise that internals (can be).
cheers,
Derick
--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Posted with an email client that doesn't mangle email: alpine
Why is this not going to git-pulls@ ? Please don't make new PRs drown in
the noise that internals (can be).
They’re hardly drowning internals. Furthermore, said patches will eventually be announced on internals anyway if they don’t get merged.
I say keep them here.
--
Andrea Faulds
http://ajf.me/
Why is this not going to git-pulls@ ? Please don't make new PRs drown in
the noise that internals (can be).They’re hardly drowning internals. Furthermore, said patches will
eventually be announced on internals anyway if they don’t get merged.I say keep them here.
I say you don't make that decision on your own. We have a list for it,
put it on there.
And right now, the subject lines are pretty useless too. On
smaller devices, I see "[PHP-DEV] [PR][php-src][#693][master][opened] - pcntl_signa"
I care neither about the repository, number, the branch, or whether it
is opened at
a glance, but merely the PR. This should go in the body of the
mail. "[PHP-DEV] [PR]" is also not needed beacuse it needs to go onto
it's already existing list.
cheers,
Derick
Why is this not going to git-pulls@ ? Please don't make new PRs drown
in
the noise that internals (can be).They’re hardly drowning internals. Furthermore, said patches will
eventually be announced on internals anyway if they don’t get merged.I say keep them here.
I say you don't make that decision on your own. We have a list for it,
put it on there.And right now, the subject lines are pretty useless too. On
smaller devices, I see "[PHP-DEV] [PR][php-src][#693][master][opened] -
pcntl_signa"I care neither about the repository, number, the branch, or whether it
is opened at
a glance, but merely the PR. This should go in the body of the
mail. "[PHP-DEV] [PR]" is also not needed beacuse it needs to go onto
it's already existing list.
[PHP-DEV] is not added by the script, but the mailing list
[PR] was added so people who aren't interested in PRs can easily filter it
same for the the repo name, I think you are right that the PR number and
status doesn't need to be in the subject, I will fix that.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Why is this not going to git-pulls@ ? Please don't make new PRs drown in
the noise that internals (can be).They’re hardly drowning internals. Furthermore, said patches will
eventually be announced on internals anyway if they don’t get merged.I say keep them here.
I say you don't make that decision on your own. We have a list for it,
put it on there.
The list is redundant. GitHub has email notifications.
It is only useful when pointed at internals. Also, we don’t get many pull requests. Finally, you shouldn’t make that decision on your own, either.
--
Andrea Faulds
http://ajf.me/