Q: When did IS_CONSTANT_ARRAY get removed?

11 years ago by Eric Stenson — view source — reply

unread

Just checking: I recently sync'd up my 5.6 tree, and I see that the #define IS_CONSTANT_ARRAY is now gone (git change f614fc68984b2d7fce3f275b8106955b5d910472 - 2014 Apr 11). This broke Wincache.

I looked at the UPGRADING.INTERNALS and UPGRADING files, but I didn't see mention of this change. Did I miss a breaking change announcement somewhere?

Thx!
--E.

11 years ago by Bob Weinand — view source — reply

unread

Am 29.4.2014 um 19:23 schrieb Eric Stenson ericsten@microsoft.com:

Just checking: I recently sync'd up my 5.6 tree, and I see that the #define IS_CONSTANT_ARRAY is now gone (git change f614fc68984b2d7fce3f275b8106955b5d910472 - 2014 Apr 11). This broke Wincache.

I looked at the UPGRADING.INTERNALS and UPGRADING files, but I didn't see mention of this change. Did I miss a breaking change announcement somewhere?

Thx!
--E.

Done.

I've added a little notice about it in UPGRADING.INTERNALS. (UPGRADING already has some information about the bug which was fixed, but internals notice was missing).

Bob