I need a bit of help here as I'm starting to doubt my sanity. Is there some
difference between the master branch and PHP-5.6 regarding zts that I'm
unaware of?
I've pushed a fix for the peer verification build breakage the code is
identical in both branches but the master branch won't build without
TSRMLS_CC and the PHP-5.6 branch will not build with the TSRMLS_CC
declaration and I'm completely flumoxed at this point.
The relevant commit can be found here:
The offending bit of code is:
if (sslsock->is_client
&& (php_stream_context_get_option(stream->context, "ssl",
"SNI_enabled", &val) == FAILURE
|| zend_is_true(*val TSRMLS_CC))
) {
Any guidance is appreciated.
I need a bit of help here as I'm starting to doubt my sanity. Is there some
difference between the master branch and PHP-5.6 regarding zts that I'm
unaware of?I've pushed a fix for the peer verification build breakage the code is
identical in both branches but the master branch won't build without
TSRMLS_CC and the PHP-5.6 branch will not build with the TSRMLS_CC
declaration and I'm completely flumoxed at this point.The relevant commit can be found here:
The offending bit of code is:
if (sslsock->is_client && (php_stream_context_get_option(stream->context, "ssl", "SNI_enabled", &val) == FAILURE || zend_is_true(*val TSRMLS_CC)) ) {Any guidance is appreciated.
The signature of zend_is_true changed between PHP-5.6 and master. In
PHP-5.6 it does not need TSRMLS_CC, in master it does.
Nikita