Hi!
I see that a lot of tests from ext/mbstring/tests/zend_multibyte* are
failing on Travis CI, with messages like:
php: Zend/zend_language_scanner.l:129:
encoding_filter_script_to_internal: Assertion `internal_encoding &&
zend_multibyte_check_lexer_compatibility(internal_encoding)' failed.
Could somebody check out what's going on with these and fix them? If
it's not possible now we should move them to XFAIL then.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
Hi Stas,
On Sun, Jan 26, 2014 at 3:27 PM, Stas Malyshev smalyshev@sugarcrm.comwrote:
I see that a lot of tests from ext/mbstring/tests/zend_multibyte* are
failing on Travis CI, with messages like:php: Zend/zend_language_scanner.l:129:
encoding_filter_script_to_internal: Assertion `internal_encoding &&
zend_multibyte_check_lexer_compatibility(internal_encoding)' failed.Could somebody check out what's going on with these and fix them? If
it's not possible now we should move them to XFAIL then.
These tests are skipped by mistake. These tests should be enabled for 5.4
and
later but they were skipped.
I recently re-enabled these tests as you may know already from commit log.
zend multibyte is working with typical configuration, so it's not a show
stopper.
Just FYI.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net
Hi!
zend multibyte is working with typical configuration, so it's not a show
stopper.
How we know it's working if most of the tests are actually failing? And
what's the point of enabling the tests that are failing and nobody cares
to fix them?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
Hi Stas,
On Mon, Jan 27, 2014 at 5:16 AM, Stas Malyshev smalyshev@sugarcrm.comwrote:
zend multibyte is working with typical configuration, so it's not a show
stopper.How we know it's working if most of the tests are actually failing? And
what's the point of enabling the tests that are failing and nobody cares
to fix them?
I think there are many. Isn't XFAIL for this purpose?
These tests were skipped since the skip condition has changed. (i.e. PHP
5.4)
It could be easy to fix, but I just don't have much time to spent for this
right now.
I may take care of them next month if nobody cares.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net