Pull requests report (18/11/2013)

On Mon, 18 Nov 2013 13:16:10 +0400, Nikita Nefedov inefedor@gmail.com
wrote:

Hi All,

I'm reporting here for three weeks, so the lists are long.
Also, the git downtime prevented merges for about a week.

New:
#509 https://github.com/php/php-src/pull/509 Bugfix for #64604
#511 https://github.com/php/php-src/pull/511 Bug #65995 - Adding FET
timezone to translate to Europe/Kaliningrad
#512 https://github.com/php/php-src/pull/512 date_diff() bug #65768
#513 https://github.com/php/php-src/pull/513 CLI: Error handling
changes
for the option parser
#518 https://github.com/php/php-src/pull/518 Fix #66021 (Blank line
inside empty array/object)
#519 https://github.com/php/php-src/pull/519 Expectations
#521 https://github.com/php/php-src/pull/521 Make PASSWORD_DEFAULT the
default algorithm in password_hash()
#523 https://github.com/php/php-src/pull/523 geallheaders php-fpm
#62596
#524 https://github.com/php/php-src/pull/524 Fix #66048 (temp.
directory
is cached during multiple requests)
#525 https://github.com/php/php-src/pull/525 Fixed tests that fail
with
non-default serialize_precision configurations
#526 https://github.com/php/php-src/pull/526 Add new 'use function'
sequence for importing namespaced functions
#527 https://github.com/php/php-src/pull/527 Fixed case part of bug
#64874 ("json_decode handles whitespace and case-sensitivity
incorrectly")#528 Implemented
FR #65917 (getallheaders() is not supported by the built-in web server)
#530 https://github.com/php/php-src/pull/530 test for unserialize
boolean
return value
#531 https://github.com/php/php-src/pull/531 Allow NULL as value for
CURLOPT_CUSTOMREQUEST option

Merged:
#287 https://github.com/php/php-src/pull/287 add ability to use array
keys with array_filter()
#456 https://github.com/php/php-src/pull/456 Fixed whitespace part of
bug
#64874 ("json_decode handles whitespace and case-sensitivity
incorrectly")
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333
Improving
multi-threaded scalability by using emalloc/efree/estrdup
#517 https://github.com/php/php-src/pull/517 mysqlnd: Fixing typo in
error message

Closed:
#223 https://github.com/php/php-src/pull/223 Bug #63380: Use PHP's
allocator for libxml
#388 https://github.com/php/php-src/pull/388 Add new 'use function'
sequence for importing namespaced functions
#435 https://github.com/php/php-src/pull/435 Cast to resource
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization
#457 https://github.com/php/php-src/pull/457 Fixed bug #64874
("json_decode handles whitespace and case-sensitivity incorrectly")
#461 https://github.com/php/php-src/pull/461 use log2() / log10()
within
basic log function
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#505 https://github.com/php/php-src/pull/505 Binsafe log
#506 https://github.com/php/php-src/pull/506 expectations
#507 https://github.com/php/php-src/pull/507 bug #54276 inconsistent
ini_get/get_cfg_var
#508 https://github.com/php/php-src/pull/508 Extract into object scope
#510 https://github.com/php/php-src/pull/510 get_headers extra
parameter
#514 https://github.com/php/php-src/pull/514 get_network_interfaces
#17400
#515 https://github.com/php/php-src/pull/515 getallheaders for php-fpm
#62596
#516 https://github.com/php/php-src/pull/516 add security.level for
php-fpm #65935
#520 https://github.com/php/php-src/pull/520 Get headers #62596
#522 https://github.com/php/php-src/pull/522 getallheaders for php-fpm
#62596
#529 https://github.com/php/php-src/pull/529 test for unserialize
boolean
return value

Still open (21 days):
#503 https://github.com/php/php-src/pull/503 Rename pcre_printint.src
to
pcre_printint.c and update from upstream
#504 https://github.com/php/php-src/pull/504 curl_seek bug #47204

Kaplan

Hi,

Following the git problems in the last few days, merges weren't
possible.

New:
#503 https://github.com/php/php-src/pull/503 Rename pcre_printint.src
to pcre_printint.c and update from upstream
#504 https://github.com/php/php-src/pull/504 curl_seek bug #47204
#505 https://github.com/php/php-src/pull/505 Binsafe log
#506 https://github.com/php/php-src/pull/506 expectations
#507 https://github.com/php/php-src/pull/507 bug #54276 inconsistent
ini_get/get_cfg_var

Merged:
#293 https://github.com/php/php-src/pull/293 Exif crash on unknown
encoding was fixed

Still open (21 days):
#479 https://github.com/php/php-src/pull/479 Replace invalid code
with
a proper #error
#486 https://github.com/php/php-src/pull/486 Client-Initiated
Renegotiation DoS Vulnerability
#487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
argument to separate the environment array
#493 https://github.com/php/php-src/pull/493 Honor cipher order
#494 https://github.com/php/php-src/pull/494 Verify SSL/TLS Peers by
Default
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333
Improving
multi-threaded scalability by using emalloc/efree/estrdup
#501 https://github.com/php/php-src/pull/501 fixed compiler warning
#502 https://github.com/php/php-src/pull/502Allow unlimited line
length in fpm config files

Kaplan

Hi,
by the way, I wonder how we should deal with timezone in tests? I wrote
a test for PR #512, but it is always failed because of timezone not
being set. I know I could set it in the code but maybe we could set such
defaults in php.ini?

I'm talking about travis

you can set it in the INI section of the test:
http://qa.php.net/phpt_details.php#ini_section

Hi All,

I'm reporting here for three weeks, so the lists are long.
Also, the git downtime prevented merges for about a week.

New:
#509 https://github.com/php/php-src/pull/509 Bugfix for #64604
#511 https://github.com/php/php-src/pull/511 Bug #65995 - Adding FET
timezone to translate to Europe/Kaliningrad
#512 https://github.com/php/php-src/pull/512 date_diff() bug #65768
#513 https://github.com/php/php-src/pull/513 CLI: Error handling
changes
for the option parser
#518 https://github.com/php/php-src/pull/518 Fix #66021 (Blank line
inside empty array/object)
#519 https://github.com/php/php-src/pull/519 Expectations
#521 https://github.com/php/php-src/pull/521 Make PASSWORD_DEFAULT the
default algorithm in password_hash()
#523 https://github.com/php/php-src/pull/523 geallheaders php-fpm
#62596
#524 https://github.com/php/php-src/pull/524 Fix #66048 (temp.
directory
is cached during multiple requests)
#525 https://github.com/php/php-src/pull/525 Fixed tests that fail with
non-default serialize_precision configurations
#526 https://github.com/php/php-src/pull/526 Add new 'use function'
sequence for importing namespaced functions
#527 https://github.com/php/php-src/pull/527 Fixed case part of bug
#64874 ("json_decode handles whitespace and case-sensitivity
incorrectly")#528 Implemented
FR #65917 (getallheaders() is not supported by the built-in web server)
#530 https://github.com/php/php-src/pull/530 test for unserialize
boolean
return value
#531 https://github.com/php/php-src/pull/531 Allow NULL as value for
CURLOPT_CUSTOMREQUEST option

Merged:
#287 https://github.com/php/php-src/pull/287 add ability to use array
keys with array_filter()
#456 https://github.com/php/php-src/pull/456 Fixed whitespace part of
bug
#64874 ("json_decode handles whitespace and case-sensitivity incorrectly")
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333 Improving
multi-threaded scalability by using emalloc/efree/estrdup
#517 https://github.com/php/php-src/pull/517 mysqlnd: Fixing typo in
error message

Closed:
#223 https://github.com/php/php-src/pull/223 Bug #63380: Use PHP's
allocator for libxml
#388 https://github.com/php/php-src/pull/388 Add new 'use function'
sequence for importing namespaced functions
#435 https://github.com/php/php-src/pull/435 Cast to resource
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization
#457 https://github.com/php/php-src/pull/457 Fixed bug #64874
("json_decode handles whitespace and case-sensitivity incorrectly")
#461 https://github.com/php/php-src/pull/461 use log2() / log10()
within
basic log function
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#505 https://github.com/php/php-src/pull/505 Binsafe log
#506 https://github.com/php/php-src/pull/506 expectations
#507 https://github.com/php/php-src/pull/507 bug #54276 inconsistent
ini_get/get_cfg_var
#508 https://github.com/php/php-src/pull/508 Extract into object scope
#510 https://github.com/php/php-src/pull/510 get_headers extra
parameter
#514 https://github.com/php/php-src/pull/514 get_network_interfaces
#17400
#515 https://github.com/php/php-src/pull/515 getallheaders for php-fpm
#62596
#516 https://github.com/php/php-src/pull/516 add security.level for
php-fpm #65935
#520 https://github.com/php/php-src/pull/520 Get headers #62596
#522 https://github.com/php/php-src/pull/522 getallheaders for php-fpm
#62596
#529 https://github.com/php/php-src/pull/529 test for unserialize
boolean
return value

Still open (21 days):
#503 https://github.com/php/php-src/pull/503 Rename pcre_printint.src
to
pcre_printint.c and update from upstream
#504 https://github.com/php/php-src/pull/504 curl_seek bug #47204

Kaplan

Hi,

Following the git problems in the last few days, merges weren't possible.

New:
#503 https://github.com/php/php-src/pull/503 Rename pcre_printint.src
to pcre_printint.c and update from upstream
#504 https://github.com/php/php-src/pull/504 curl_seek bug #47204
#505 https://github.com/php/php-src/pull/505 Binsafe log
#506 https://github.com/php/php-src/pull/506 expectations
#507 https://github.com/php/php-src/pull/507 bug #54276 inconsistent
ini_get/get_cfg_var

Merged:
#293 https://github.com/php/php-src/pull/293 Exif crash on unknown
encoding was fixed

Still open (21 days):
#479 https://github.com/php/php-src/pull/479 Replace invalid code with
a proper #error
#486 https://github.com/php/php-src/pull/486 Client-Initiated
Renegotiation DoS Vulnerability
#487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
argument to separate the environment array
#493 https://github.com/php/php-src/pull/493 Honor cipher order
#494 https://github.com/php/php-src/pull/494 Verify SSL/TLS Peers by
Default
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333
Improving
multi-threaded scalability by using emalloc/efree/estrdup
#501 https://github.com/php/php-src/pull/501 fixed compiler warning
#502 https://github.com/php/php-src/pull/502Allow unlimited line
length in fpm config files

Kaplan

Hi,
by the way, I wonder how we should deal with timezone in tests? I wrote a
test for PR #512, but it is always failed because of timezone not being
set. I know I could set it in the code but maybe we could set such defaults
in php.ini?

--

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

On Mon, Nov 18, 2013 at 10:30 AM, Kevin Ingwersen <ingwie2000@googlemail.com

wrote:

Hello, I have a question:

Am 18.11.2013 um 10:08 schrieb Lior Kaplan lior.k@zend.com:

#500 https://github.com/php/php-src/pull/500 Fixed bug #50333
Improving
multi-threaded scalability by using emalloc/efree/estrdup

What exactly does this mean? I only know that you can use pthreads
extension to make PHP become multi-threaded. So what is this part of the
report meaning?

Kind regards,
Ingwie

php supports thread safe builds, which can be used to spawn the workers as
threads instead of separate processes, this was the default/preferred way
for IIS on windows for some time, but AFAIK nowadays it is fastcgi there
too.

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu