Pull requests report (23/9/2013)

12 years ago by Lior Kaplan — view source — reply

unread

Hi,

2nd week in a row that we get a lot of new pull requests. Any thoughts
about how can we process them faster (especially bug fixes)? Other projects
use 2 reviewers before commit or similar methods.

Total requests: 77

New:
#455 https://github.com/php/php-src/pull/455 Fix missing symbol linking
error on (ancient) systems without atoll, e.g. AIX5.1
#456 https://github.com/php/php-src/pull/456 Fixed whitespace part of bug
#64874 ("json_decode handles whitespace and case-sensitivity incorrectly")
#457 https://github.com/php/php-src/pull/457 Fixed part of bug #64874
("json_decode handles whitespace and case-sensitivity incorrectly")
#458 https://github.com/php/php-src/pull/458 Add ldap_escape()
#459 https://github.com/php/php-src/pull/459 Bug 65701
#460 https://github.com/php/php-src/pull/460 json_encode(): added option
to turn only empty arrays into object
#461 https://github.com/php/php-src/pull/461 use log2() / log10() within
basic log function
#462 https://github.com/php/php-src/pull/462 Bug 64744
#463 https://github.com/php/php-src/pull/463 fix bug #53432 (Assignment
via string index access on an empty string converts to array)
#464 https://github.com/php/php-src/pull/464 openssl: certificate
fingerprinting support
#465 https://github.com/php/php-src/pull/465 Better wildcard matching for
CN
#466 https://github.com/php/php-src/pull/466 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#467 https://github.com/php/php-src/pull/467 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#468 https://github.com/php/php-src/pull/468 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#469 https://github.com/php/php-src/pull/469 Streams: Configure crypto
method for ssl:// transports
#470 https://github.com/php/php-src/pull/470 anon class objects

Merged:
#372 https://github.com/php/php-src/pull/372 Allow uploading files > 2G
(bug 44522)
#452 https://github.com/php/php-src/pull/452 Add RFC 6598 IPs to reserved
addresses

Closed (without merge):
#397 https://github.com/php/php-src/pull/397 New handler for retrieving
properties when object is serialized
#406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache
causing strangeness
#436 https://github.com/php/php-src/pull/436 Fixed bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#454 https://github.com/php/php-src/pull/454 json_encode(): option to
only encode empty arrays as objects

Still open (21 days):
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls
#427 https://github.com/php/php-src/pull/427 run-tests.php: Added
EXPECT_EXTERNAL, EXPECTF_EXTERNAL, EXPECTREGEX_EXTERNAL #55736
#428 https://github.com/php/php-src/pull/428 Fixed bug #48770: when
call_user_func() fails to call parent from inheriting class (2)
#429 https://github.com/php/php-src/pull/429 Segfault fix for more than
one modules
#430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
S-box for GOST
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()
#432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
DATE_SQLTIMESTAMP constants
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes
#435 https://github.com/php/php-src/pull/435 Cast to resource
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting error
message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization

Kaplan

In the past week we've been "hammered" with 18 new pull requests, which
I'm happy with (especially with the other internals discussions). But now
the hard reviewing work begins, any help would be welcomed.

Thank you David Soria Parra for the merges and cleanup, and thank you
Nikita Popov for the merges this week.

New:
#435 https://github.com/php/php-src/pull/435 Cast to resource
#436 https://github.com/php/php-src/pull/436 Fixed bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting
error message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#452 https://github.com/php/php-src/pull/452 Add RFC 6598 IPs to
reserved addresses
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization

Merged:
#439 https://github.com/php/php-src/pull/439 Bug 65548
#440 https://github.com/php/php-src/pull/440 Bug 65502
#443 https://github.com/php/php-src/pull/443 Fixed minor bug in SPL test
#444 https://github.com/php/php-src/pull/444 EmptyIterator now
implements Countable; fixes bug 60577
#445 https://github.com/php/php-src/pull/445 Bug 64157

Closed (without merge):
#290 https://github.com/php/php-src/pull/290 Fixed bug #64280
#324 https://github.com/php/php-src/pull/324 Fixed memory leak in
strtotime
#337 https://github.com/php/php-src/pull/337 Feature/log2
#338 https://github.com/php/php-src/pull/338 Adding a new
mysqli::bind_value method
#353 https://github.com/php/php-src/pull/353 Add new function
string_is_ascii
#367 https://github.com/php/php-src/pull/367 Php 5.4 strict session
collision detection
#422 https://github.com/php/php-src/pull/422 Add test for bug #60598
#450 https://github.com/php/php-src/pull/450 disable unsafe optimization

Still open (21 days):
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize & pcntl_setaffinity
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters
#424 https://github.com/php/php-src/pull/424 Signature is valid if
there are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Kaplan