Pull requests report (16/9/2013)

12 years ago by Lior Kaplan — view source — reply

unread

In the past week we've been "hammered" with 18 new pull requests, which I'm
happy with (especially with the other internals discussions). But now the
hard reviewing work begins, any help would be welcomed.

Thank you David Soria Parra for the merges and cleanup, and thank you
Nikita Popov for the merges this week.

New:
#435 https://github.com/php/php-src/pull/435 Cast to resource
#436 https://github.com/php/php-src/pull/436 Fixed bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting error
message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#452 https://github.com/php/php-src/pull/452 Add RFC 6598 IPs to reserved
addresses
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization

Merged:
#439 https://github.com/php/php-src/pull/439 Bug 65548
#440 https://github.com/php/php-src/pull/440 Bug 65502
#443 https://github.com/php/php-src/pull/443 Fixed minor bug in SPL test
#444 https://github.com/php/php-src/pull/444 EmptyIterator now implements
Countable; fixes bug 60577
#445 https://github.com/php/php-src/pull/445 Bug 64157

Still open (21 days):
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize & pcntl_setaffinity
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters
#424 https://github.com/php/php-src/pull/424 Signature is valid if there
are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Kaplan

Hi,

The last week brought quite a few new pull requests. I hope we'll keep see
new people getting involved.

New:
#427 https://github.com/php/php-src/pull/427 run-tests.php: Added
EXPECT_EXTERNAL, EXPECTF_EXTERNAL, EXPECTREGEX_EXTERNAL #55736
#428 https://github.com/php/php-src/pull/428 Fixed bug #48770: when
call_user_func() fails to call parent from inheriting class (2)
#429 https://github.com/php/php-src/pull/429 Segfault fix for more than
one modules
#430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
S-box for GOST
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()
#432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
DATE_SQLTIMESTAMP constants
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes

Merged:
(none)

Closed (without merge):
#433 https://github.com/php/php-src/pull/433 undefine user constants at
runtime

Still open (21 days):
#413 https://github.com/php/php-src/pull/413 Make exception messages
and error output binary safe
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize & pcntl_setaffinity
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters
#422 https://github.com/php/php-src/pull/422 Add test for bug #60598
#424 https://github.com/php/php-src/pull/424 Signature is valid if
there are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Kaplan