Hi, all.
I'm going to rename functions from oci8 to match the naming-conventions.
Old names will be kept as aliases, of course, but should be deprecated.
Imho these changes will make OCI extsension more handy and it's API more similar to other extensions' API.
I'd like to hear your opinions about new names and necessity of this renaming.
ocibindbyname -> oci_bind_by_name
ocidefinebyname -> oci_define_by_name
All Lob functions will be renamed to oci_lob_*
ociloadlob -> oci_lob_load
ocicloselob -> oci_lob_close
ocisavelob -> oci_lob_save (I'm not sure we need this one, cause I plan to make $Lob->append() able to receive strings and Lobs as parameter)
ocisavelobfile -> oci_lob_import ($Lob->import())
ociwritelobtofile -> oci_lob_export ($Lob->export())
ociwritetemporarylob -> oci_lob_write_temporary ()
All collection functions will be renamed to oci_collection_*
ocicollappend -> oci_collection_append
ocicollassign -> oci_collection_assign
ocicollassignelem -> oci_collection_element_assign
ocicollgetelem -> oci_collection_element_get
ocicollmax -> oci_collection_max
ocicollsize -> oci_collection_size
ocicolltrim -> oci_collection_trim
All functions with column in the name will sound as field.
We call it "field" in all other DB API's, so I don't see any reason why we should call it differently here.
ocicolumnisnull -> oci_field_is_null
ocicolumnname -> oci_field_name
ocicolumnprecision -> oci_field_precision
ocicolumnscale -> oci_field_scale
ocicolumnsize -> oci_field_size
ocicolumntype -> oci_field_type
ocicolumntyperaw -> oci_field_type_raw
ocifetchinto -- this is a special case. I'd prefer to make 3 functions instead of it: oci_fetch_row, oci_fetch_array & oci_fetch_assoc
ocifetchstatement -> oci_fetch_all
ocifreecollection -> oci_free_collection (as I can see, this form is more widespread, than oci_collection_free() )
ocifreecursor -> oci_free_cursor
ocifreedesc -> oci_free_descriptor
ocifreestatement -> oci_free_statement
ociinternaldebug -> oci_internal_debug
ocicancel -> oci_cancel
ocicommit -> oci_commit
ocierror -> oci_error
ociexecute -> oci_execute
ocifetch -> oci_fetch
ocilogoff -> oci_logoff (or oci_close ?)
ocilogon -> oci_logon (or oci_connect ?)
ocinewcollection -> oci_new_collection
ocinewcursor -> oci_new_cursor
ocinewdescriptor -> oci_new_descriptor
ocinlogon -> oci_new_logon
ocinumcols -> oci_num_fields
ociparse -> oci_parse
ociplogon -> oci_plogon (or oci_pconnect would be better?)
ociresult -> oci_result
ocirollback -> oci_rollback
ocirowcount -> oci_num_rows
ociserverversion -> oci_server_version
ocisetprefetch -> oci_set_prefetch
ocistatementtype -> oci_statement_type
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net
Hi, all.
I'm going to rename functions from oci8 to match the naming-conventions.
Old names will be kept as aliases, of course, but should be deprecated.
Imho these changes will make OCI extsension more handy and it's API more similar to other extensions' API.
I'd like to hear your opinions about new names and necessity of this renaming.ocibindbyname -> oci_bind_by_name
ocidefinebyname -> oci_define_by_nameAll Lob functions will be renamed to oci_lob_*
[...snip...]
ociinternaldebug -> oci_internal_debugocicancel -> oci_cancel
ocicommit -> oci_commit
ocierror -> oci_error
ociexecute -> oci_execute
ocifetch -> oci_fetch
ocilogoff -> oci_logoff (or oci_close ?)
ocilogon -> oci_logon (or oci_connect ?)
ocinewcollection -> oci_new_collection
ocinewcursor -> oci_new_cursor
ocinewdescriptor -> oci_new_descriptor
ocinlogon -> oci_new_logon
ocinumcols -> oci_num_fields
ociparse -> oci_parse
ociplogon -> oci_plogon (or oci_pconnect would be better?)
ociresult -> oci_result
ocirollback -> oci_rollback
ocirowcount -> oci_num_rows
ociserverversion -> oci_server_version
ocisetprefetch -> oci_set_prefetch
ocistatementtype -> oci_statement_type
oci_[p]connect() and oci_close() would be consistent with other database
extensions. Otherwise it looks good to me.
- Stig
--
"Nearly all men can stand adversity, but if you want to test a man's
character, give him power." - Abraham Lincoln
On Wed, Dec 17, 2003 at 08:00:06PM +0300, Antony Dovgal wrote :
ocifetchinto -- this is a special case. I'd prefer to make 3 functions
instead of it: oci_fetch_row, oci_fetch_array & oci_fetch_assoc
Just curious; there are other extension which provide
*fetch_object() too. Did you leave it out intentionally?
- Markus
On Thu, 18 Dec 2003 08:13:13 +0100
Markus Fischer mfischer@gjat.josefine.at wrote:
On Wed, Dec 17, 2003 at 08:00:06PM +0300, Antony Dovgal wrote :
ocifetchinto -- this is a special case. I'd prefer to make 3 functions
instead of it: oci_fetch_row, oci_fetch_array & oci_fetch_assocJust curious; there are other extension which provide *fetch_object() too. Did you leave it out intentionally?
oops.
just forgot about it.
of course, such functions should be in OCI8 too.
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net
On Wed, 17 Dec 2003 20:00:06 +0300
Antony Dovgal tony2001@phpclub.net wrote:
Hi, all.
I'm going to rename functions from oci8 to match the naming-conventions.
Old names will be kept as aliases, of course, but should be deprecated.
Imho these changes will make OCI extsension more handy and it's API more similar to other extensions' API.
I'd like to hear your opinions about new names and necessity of this renaming.
Ok, it seems, that nobody objects and I'm going to commit the patch in some minutes.
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net