submitting a patch

13 years ago by William Betts — view source — reply

unread

Hello,

I've been looking around for a while, but I haven't been able to figure out
where I would send a patch for the curl extension. If anyone could point me
to the documentation outline the process for that it would be appreciated.

Best Regards,
William

13 years ago by Pierrick Charron — view source — reply

unread

Hi the best way to submit a patch is to fork the project on
github.com/php/php-src and to send a pull request.
If your patch is related to a bug, you can also attach it to the bug report.

Thanks
Pierrick

Hello,

I've been looking around for a while, but I haven't been able to figure out
where I would send a patch for the curl extension. If anyone could point me
to the documentation outline the process for that it would be appreciated.

Best Regards,
William

13 years ago by William Betts — view source — reply

unread

On Sat, 26 May 2012 19:21:15 -0700, Pierrick Charron pierrick@webstart.fr
wrote:

Hi the best way to submit a patch is to fork the project on

github.com/php/php-src and to send a pull request.
If your patch is related to a bug, you can also attach it to the bug
report.

Thanks
Pierrick

Hello,

I've been looking around for a while, but I haven't been able to figure
out
where I would send a patch for the curl extension. If anyone could point
me
to the documentation outline the process for that it would be
appreciated.

Best Regards,
William

Hopefully this email doesn't get duplicated to this list. If this comes
through twice I'm sorry!

Well, I just discovered what I was about to add has been partially
implemented (CURL SMTP support). I'll go ahead and implement the missing
feature (CURLOPT_MAIL_AUTH). I've also just submitted some patches
to libcurl as well. If Dan approves them there I'll go ahead an add that in
as well.

Thank you for the heads up about git!

Best Regards,
William