I'm trying to upload the latest getters/setters patch to: https://bugs.php.net/bug.php?id=49526
I get "Uploaded file is empty or nothing was uploaded."
Is there a problem or a file size limit? The patch file is 205k now.
-Clint
I'm trying to upload the latest getters/setters patch to: https://bugs.php.net/bug.php?id=49526
I get "Uploaded file is empty or nothing was uploaded."
Is there a problem or a file size limit? The patch file is 205k now.
Really, a 200k patch? Why is it so big?
There is a 100k limit, but the error message you are getting indicates
that you aren't actually hitting that limitation. The server config has
a 2M limit, so you should be fitting well within that. I'm not sure how
your 200k patch is hittig that "file is empty" condition in the code.
Put it somewhere else and add a link in the report. And if someone has a
lot of free time they may go read your 200k patch.
-Rasmus
Hi!
I'm trying to upload the latest getters/setters patch to: https://bugs.php.net/bug.php?id=49526
I get "Uploaded file is empty or nothing was uploaded."
Is there a problem or a file size limit? The patch file is 205k now.
BTW, I would recommend using Wiki and RFC for tracking new features,
especially of this magnitude. This is obviously not a bug, and not a
small feature request either...
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
BTW, I would recommend using Wiki and RFC for tracking new features,
especially of this magnitude. This is obviously not a bug, and not a small
feature request either...
the RFC is already in the wiki, AFAIR it is linked from the ticket also.
https://wiki.php.net/rfc/propertygetsetsyntax
https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Okay... Pierre had recommended I upload the patches to that bug report when I first got started. I just finished getting the last of the hard stuff working tonight. The patch is pretty big (though the 200k may have had a lot of white-space changes).
It may also be so big because that patch included updates to the Reflection extension as well as tests for just about everything, plenty of code there.
Would it be best to break apart the code into sets of diffs, such as:
- Reflection
- Reflection Tests
- Feature
- Feature Tests
Thanks,
-Clint
-----Original Message-----
From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
Sent: Saturday, January 28, 2012 4:00 PM
To: Stas Malyshev
Cc: Rasmus Lerdorf; Clint M Priest; internals@lists.php.net
Subject: Re: [PHP-DEV] Uploading a patch fails...
BTW, I would recommend using Wiki and RFC for tracking new features,
especially of this magnitude. This is obviously not a bug, and not a
small feature request either...
the RFC is already in the wiki, AFAIR it is linked from the ticket also.
https://wiki.php.net/rfc/propertygetsetsyntax
https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
There is a 100k limit, but the error message you are getting indicates
that you aren't actually hitting that limitation. The server config has
a 2M limit, so you should be fitting well within that. I'm not sure how
your 200k patch is hittig that "file is empty" condition in the code.
You mean upload_max_filesize is 2M?
What about post_max_size ? That could well lead to that condition.
2012/1/28 Ángel González keisial@gmail.com:
There is a 100k limit, but the error message you are getting indicates
that you aren't actually hitting that limitation. The server config has
a 2M limit, so you should be fitting well within that. I'm not sure how
your 200k patch is hittig that "file is empty" condition in the code.You mean upload_max_filesize is 2M?
What about post_max_size ? That could well lead to that condition.
post_max_size = 8M
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu