Hey Gustavo, you added a simple http server and some tests a year ago. I
think we have some bitrot on them as they are all failing for me and
also on gcov:
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug38802.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug48929.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug53198.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fignore_errors.phpt
Could you have a look at them? They probably should be moved to the
embedded http server at some point, but for now it would be good to just
get the tests fixed.
-Rasmus
On Sat, 12 Nov 2011 20:40:53 +0100, Rasmus Lerdorf rasmus@lerdorf.com
wrote:
Hey Gustavo, you added a simple http server and some tests a year ago. I
think we have some bitrot on them as they are all failing for me and
also on gcov:http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug38802.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug48929.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fbug53198.phpt
http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests&file=ext%2Fstandard%2Ftests%2Fhttp%2Fignore_errors.phptCould you have a look at them? They probably should be moved to the
embedded http server at some point, but for now it would be good to just
get the tests fixed.
Actually, it was Arnaud Le Blanc who added the server (see
ext/standard/tests/http/server.inc).
In any case, I'll gladly take a look at them later today when I'm back
home.
--
Gustavo Lopes