Hi,
I started debugging why ext/pcre/tests/006.phpt fails, I've pinpointed
the guilty commit:
http://svn.php.net/viewvc?view=revision&revision=311323
it seems that the behavior was depending on the backtrack limit, but
I'm not sure what to do with the test.
should I simply delete? or can we change the patter in such way that
it would return NULL
again?
I'm not even sure what are we testing there. :/
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Hi!
http://svn.php.net/viewvc?view=revision&revision=311323
it seems that the behavior was depending on the backtrack limit, but
I'm not sure what to do with the test.
should I simply delete? or can we change the patter in such way that
it would returnNULL
again?
I'm not even sure what are we testing there. :/
This tests works for me. What is the failure in your case?
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are
ok. It seems it starts to fail after Rasmus's default backtrack limit
increasion (as Tyrael pointed in his message), which was fixed for
PHP_5_4 and trunk in this commit:
http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3
branch should be changed accordingly?
2011/9/4 Stas Malyshev smalyshev@sugarcrm.com:
Hi!
http://svn.php.net/viewvc?view=revision&revision=311323
it seems that the behavior was depending on the backtrack limit, but
I'm not sure what to do with the test.
should I simply delete? or can we change the patter in such way that
it would returnNULL
again?
I'm not even sure what are we testing there. :/This tests works for me. What is the failure in your case?
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227--
--
Regards,
Shein Alexey
thanks, I should have mentioned that I was playing with the 5_3 branch.
It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are
ok. It seems it starts to fail after Rasmus's default backtrack limit
increasion (as Tyrael pointed in his message), which was fixed for
PHP_5_4 and trunk in this commit:
http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3
branch should be changed accordingly?2011/9/4 Stas Malyshev smalyshev@sugarcrm.com:
Hi!
http://svn.php.net/viewvc?view=revision&revision=311323
it seems that the behavior was depending on the backtrack limit, but
I'm not sure what to do with the test.
should I simply delete? or can we change the patter in such way that
it would returnNULL
again?
I'm not even sure what are we testing there. :/This tests works for me. What is the failure in your case?
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227--
--
Regards,
Shein Alexey
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are
ok. It seems it starts to fail after Rasmus's default backtrack limit
increasion (as Tyrael pointed in his message), which was fixed for
PHP_5_4 and trunk in this commit:
http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3
branch should be changed accordingly?
I've just did that, thanks for the tip.
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/pcre/tests/006.phpt?r1=316107&r2=316106&pathrev=316107
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu