Confusing performance of the magic method __call

14 years ago by Shijiang — view source

unread

Hi,

In the following sample code, I expected that the magic method __call only works within the class Test.
But it seems that the access control keyword private lost its efficacy when working together with the magic method __call.

<?php
class Test{
private function __call($name,$params){
echo $name,"\n";
echo $params[0];
}

public function bar(){   
    $this->kakaka('afaafaf');
}

}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey the visibility rules.

Cheers.

14 years ago by Ferenc Kovacs — view source

unread

2010/8/3 Shijiang shijiang@staff.sina.com.cn:

Hi,

In the following sample code, I expected that the magic method __call only works within the class Test.
But it seems that the access control keyword private lost its efficacy when working together with the magic method __call.

<?php
class Test{
private function __call($name,$params){
echo $name,"\n";
echo $params[0];
}

public function bar(){
$this->kakaka('afaafaf');
}
}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey the visibility rules.

Cheers.

http://www.php.net/manual/en/migration53.incompatible.php

The magic methods __get, __set, __isset, __unset, and __call must
always be public and can no longer be static. Method signatures are
now enforced.

Tyrael

14 years ago by Victor Bolshov — view source

unread

Shijiang, did you notice the

--
Warning: The magic method __call() must have public visibility and cannot be
static in Command line code on line 1

???

2010/8/3 Shijiang shijiang@staff.sina.com.cn

Hi,

In the following sample code, I expected that the magic method __call only
works within the class Test.
But it seems that the access control keyword private lost its efficacy when
working together with the magic method __call.

<?php
class Test{
private function __call($name,$params){
echo $name,"\n";
echo $params[0];
}

public function bar(){
$this->kakaka('afaafaf');
}
}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey the
visibility rules.

Cheers.

--
С уважением,
Виктор

14 years ago by Ferenc Kovacs — view source

unread

2010/8/3 Victor Bolshov crocodile2u@gmail.com:

Shijiang, did you notice the

--
Warning: The magic method __call() must have public visibility and cannot be
static in Command line code on line 1

???

2010/8/3 Shijiang shijiang@staff.sina.com.cn

Hi,

In the following sample code, I expected that the magic method __call only
works within the class Test.
But it seems that the access control keyword private lost its efficacy when
working together with the magic method __call.

<?php
class Test{
private function __call($name,$params){
echo $name,"\n";
echo $params[0];
}

public function bar(){
$this->kakaka('afaafaf');
}
}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey the
visibility rules.

Cheers.

--
С уважением,
Виктор

It was added/changed with 5.3 so it is not necessarly obvious.

Tyrael

14 years ago by Victor Bolshov — view source

unread

Yes, sorry. I've been working with 5.3 for pretty long time so I found the
original letter a bit strange.

2010/8/3 Ferenc Kovacs info@tyrael.hu

2010/8/3 Victor Bolshov crocodile2u@gmail.com:

Shijiang, did you notice the

--
Warning: The magic method __call() must have public visibility and cannot
be
static in Command line code on line 1

???

2010/8/3 Shijiang shijiang@staff.sina.com.cn

Hi,

In the following sample code, I expected that the magic method __call
only
works within the class Test.
But it seems that the access control keyword private lost its efficacy
when
working together with the magic method __call.

<?php
class Test{
private function __call($name,$params){
echo $name,"\n";
echo $params[0];
}

public function bar(){
$this->kakaka('afaafaf');
}
}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey
the
visibility rules.

Cheers.

--
С уважением,
Виктор

It was added/changed with 5.3 so it is not necessarly obvious.

Tyrael

--
С уважением,
Виктор

14 years ago by Shijiang — view source

unread

I was working with PHP 5.2.9 with error_report=E_ALL and display_errors=On and got no error at all.

Just now I tried it under PHP 5.3.0 and got the warning.

Sometimes although I declared the magic method __call(), I want to prevent it from being called outside the class.
Could someone be kindly enough to tell me why it must be public?

Thanks.
----- Original Message -----
From: Victor Bolshov
To: Shijiang
Cc: PHP internals
Sent: Tuesday, August 03, 2010 7:15 PM
Subject: Re: [PHP-DEV] Confusing performance of the magic method __call

Shijiang, did you notice the

--
Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1

???

2010/8/3 Shijiang shijiang@staff.sina.com.cn

Hi,

In the following sample code, I expected that the magic method __call only works within the class Test.
But it seems that the access control keyword private lost its efficacy when working together with the magic method __call.

&lt;?php
class Test{
   private function __call($name,$params){
       echo $name,"\n";
       echo $params[0];
   }

   public function bar(){
       $this->kakaka('afaafaf');
   }
}
$foo=new Test;
$foo->bar('sfsfss');
$foo->nothing('works'); // this also works without any errors.
?>

IMHO, since the function __call is a method of a class, it should obey the visibility rules.

Cheers.

--
С уважением,
Виктор

14 years ago by Guillaume Rossolini — view source

unread

2010/8/4 Shijiang shijiang@staff.sina.com.cn

I was working with PHP 5.2.9 with error_report=E_ALL and display_errors=On
and got no error at all.

Just now I tried it under PHP 5.3.0 and got the warning.

Sometimes although I declared the magic method __call(), I want to prevent
it from being called outside the class.
Could someone be kindly enough to tell me why it must be public?

Thanks.

Hi,

To get the error messages mentioned above, you might want to try the
following error reporting level: E_ALL | E_STRICT
Please refer to the manual to understand why E_ALL does not actually mean
all error levels:
http://www.php.net/manual/en/function.error-reporting.php (below "Notes")

Also, your php.ini file for PHP 5.3 has details explaining why this version
includes E_STRICT (I am guessing you chose the "development" version).

As for your other question regarding why the magic method visibility works
as it does, the answer has been given in the following bug reports:
http://bugs.php.net/bug.php?id=40056
http://bugs.php.net/bug.php?id=44769

Regards,

--
Guillaume Rossolini

Confusing performance of the magic method __call

-- Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1

-- Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1

-- Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1

-- Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1

--
Warning: The magic method __call() must have public visibility and cannot be
static in Command line code on line 1

--
Warning: The magic method __call() must have public visibility and cannot be
static in Command line code on line 1

--
Warning: The magic method __call() must have public visibility and cannot
be
static in Command line code on line 1

--
Warning: The magic method __call() must have public visibility and cannot be static in Command line code on line 1