Hi,
I've updated each of the following bug reports
http://bugs.php.net/bug.php?id=50475 - DateTime::setISODate followed
by DateTime::setTime
http://bugs.php.net/bug.php?id=49059 - DateTime::diff() repeats
previous sub() operation
http://bugs.php.net/bug.php?id=49904 - DateTime::modify('last day')
returns last day of the month
with a patch (against 5.3) that includes a fix as well as a test case.
50475 is the only one that is currently unassigned. Please could
someone review my fix.
Thanks,
Arvi
A few more patches (and test cases) for review:
http://bugs.php.net/bug.php?id=46111 (strtotime() returns false for
some valid timezones)
http://bugs.php.net/bug.php?id=48902 ( datetimezone uses calcutta or kolkata)
http://bugs.php.net/bug.php?id=50559 (Clone is not implemented for
DateInterval and DatePeriod)
Thanks,
Arvi
Hi,
I've updated each of the following bug reports
http://bugs.php.net/bug.php?id=50475 - DateTime::setISODate followed
by DateTime::setTimehttp://bugs.php.net/bug.php?id=49059 - DateTime::diff() repeats
previous sub() operationhttp://bugs.php.net/bug.php?id=49904 - DateTime::modify('last day')
returns last day of the monthwith a patch (against 5.3) that includes a fix as well as a test case.
50475 is the only one that is currently unassigned. Please could
someone review my fix.Thanks,
Arvi
I've updated each of the following bug reports
http://bugs.php.net/bug.php?id=50475 - DateTime::setISODate followed
by DateTime::setTimehttp://bugs.php.net/bug.php?id=49059 - DateTime::diff() repeats
previous sub() operationhttp://bugs.php.net/bug.php?id=49904 - DateTime::modify('last day')
returns last day of the monthwith a patch (against 5.3) that includes a fix as well as a test case.
50475 is the only one that is currently unassigned. Please could
someone review my fix.
Like I just added to that bug report (I think), I'll be having some time
next week to look at all your patches. Thanks!
with kind regards,
Derick
--
http://derickrethans.nl | http://xdebug.org
twitter: @derickr
Thanks Derick.
Please could you point me to info on how the timelib_timezone_db_data
(in ext/date/lib/timezonedb.h) is generated.
/* This is a generated file, do not modify */
const unsigned char timelib_timezone_db_data_builtin[257664] = {
(A couple of the timezone related bugs I looked at used logic that
indexed into this structure)
Cheers,
Arvi
Hi Derick,
When you have some time, please could you review the patches I've
added to each of the following date/time-related bugs.
If the fix for 49778 is applied, then I'll need to change one of the
other test cases (50559) that prints the days value of DateInterval
objects.
http://bugs.php.net/bug.php?id=49778 DateInterval::format("%a") is always zero
http://bugs.php.net/bug.php?id=50475 - DateTime::setISODate followed
by DateTime::setTime
http://bugs.php.net/bug.php?id=49059 - DateTime::diff() repeats
previous sub() operation
http://bugs.php.net/bug.php?id=49904 - DateTime::modify('last day')
returns last day of the month
http://bugs.php.net/bug.php?id=46111 (strtotime() returns false for
some valid timezones)
http://bugs.php.net/bug.php?id=48902 ( datetimezone uses calcutta or kolkata)
http://bugs.php.net/bug.php?id=50559 (Clone is not implemented for
DateInterval and DatePeriod)
Thanks,
Arvi