[PHP-CVS] cvs: php-src /win32/build confutils.js

17 years ago by Steph Fox — view source

unread

If it is not possible to test a change, it is always good to take a
look at the snaps log. There was first an error about the confutils.js
script, runtime error.

Now that's just weird, because I did test that. No errors here.

Even weirder. There's no error in the snaps log regarding confutils.js at
all.

So what are you talking about? Can you show me?

Still can't reproduce this, even with a snapshot build. Could you please put
the code back as it was - i.e, working?

Thanks,

Steph

17 years ago by Pierre Joye — view source

unread

If it is not possible to test a change, it is always good to take a
look at the snaps log. There was first an error about the confutils.js
script, runtime error.

Now that's just weird, because I did test that. No errors here.

Even weirder. There's no error in the snaps log regarding confutils.js at
all.

So what are you talking about? Can you show me?

Still can't reproduce this, even with a snapshot build. Could you please put
the code back as it was - i.e, working?

http://snaps.php.net/win32/snapshot-6.0.log (last log (06:30):

info.c
ext\standard\info.c(559) : error C2065: 'PHP_WINAPI_COMPILER' :
undeclared identifier

Can we now move on please? I really have other things to do that
explaining why/what/where is (it) broken, problem solved, let us go
back to work now.

--
Pierre

http://blog.thepimp.net | http://www.libgd.org

17 years ago by Steph Fox — view source

unread

http://snaps.php.net/win32/snapshot-6.0.log (last log (06:30):

info.c
ext\standard\info.c(559) : error C2065: 'PHP_WINAPI_COMPILER' :
undeclared identifier

That has nothing to do with either configure.js or confutils.js.

Can we now move on please? I really have other things to do that
explaining why/what/where is (it) broken, problem solved, let us go
back to work now.

Would you please put my working code back into confutils.js?

Thank you,

Steph

17 years ago by Pierre Joye — view source

unread

http://snaps.php.net/win32/snapshot-6.0.log (last log (06:30):

info.c
ext\standard\info.c(559) : error C2065: 'PHP_WINAPI_COMPILER' :
undeclared identifier

That has nothing to do with either configure.js or confutils.js.

Can you PLEASE read ALL my answer before replying withing seconds?

There was two problems:

the confutil.js
the info.c

--
Pierre
http://blog.thepimp.net | http://www.libgd.org

17 years ago by Steph Fox — view source

unread

info.c
ext\standard\info.c(559) : error C2065: 'PHP_WINAPI_COMPILER' :
undeclared identifier

That has nothing to do with either configure.js or confutils.js.

Can you PLEASE read ALL my answer before replying withing seconds?

There was two problems:

the confutil.js

the info.c

I did. But a) I can't reproduce any issues at all with confutils.js prior to
your changes and b) there's no log pertaining to any config-related error at
all. If the error ever existed, I'd like to know what it was so that I can
fix the code properly, as opposed to simply reverting the code to a point
where it can't work.

Thanks,

Steph

17 years ago by Pierre Joye — view source

unread

info.c
ext\standard\info.c(559) : error C2065: 'PHP_WINAPI_COMPILER' :
undeclared identifier

That has nothing to do with either configure.js or confutils.js.

Can you PLEASE read ALL my answer before replying withing seconds?

There was two problems:

the confutil.js

the info.c

I did. But a) I can't reproduce any issues at all with confutils.js prior to
your changes and b) there's no log pertaining to any config-related error at
all. If the error ever existed, I'd like to know what it was so that I can
fix the code properly, as opposed to simply reverting the code to a point
where it can't work.

From yesterday:

<johannes> [17:47:26] c:\php4build\snap\configure.js(1342, 4)
Microsoft JScript runtime error: Unknown runtime error
<johannes> [17:47:30] http://snaps.php.net/win32/snapshot-6.0.log

Now stop to discuss this problem. If there is anything left not merged
in HEAD then please send a patch. If not, then the problem is solved,
end of the discussion.

--
Pierre

http://blog.thepimp.net | http://www.libgd.org

17 years ago by Steph Fox — view source

unread

From yesterday:

From yesterday?! Well, that would explain why it does no good to follow
your instructions and look at the snaps log, wouldn't it?

<johannes> [17:47:26] c:\php4build\snap\configure.js(1342, 4)
Microsoft JScript runtime error: Unknown runtime error
<johannes> [17:47:30] http://snaps.php.net/win32/snapshot-6.0.log

Y'know, email works... it would've been very simple to just notify me of
both issues at the time rather than setting up a public argument about
either/both a day later.

Now stop to discuss this problem. If there is anything left not merged
in HEAD then please send a patch. If not, then the problem is solved,
end of the discussion.

There will be, because obviously that code is working in 5_3.

Steph