It is too difficult for extension that is not in the core distribution
yet.
For now I think it is simple to override zend_stream_open_function() and
zend_resolve_path_function() callbacks by ext/phar and provide something
like phar.include_path directive.
Thanks. Dmitry.
-----Original Message-----
From: Pierre Joye [mailto:pierre.php@gmail.com]
Sent: Thursday, March 13, 2008 2:12 PM
To: Dmitry Stogov
Cc: Gregory Beaver; internals Mailing List
Subject: Re: [PHP-DEV] RE: [PATCH] adding stream wrappers to
include_pathOn Thu, Mar 13, 2008 at 11:55 AM, Dmitry Stogov
dmitry@zend.com wrote:Hi Greg,
In general include_path cannot contain pathes with ':' character,
because it is the POSIX path separator. So I don't see a
way to use
stream wrappers in include_path. :(What's about quotes or escape? Quotes are somehow more
readable and are already used in many places (generally not
specifically in PHP). I can imagine a:set_include_path('"foo://something/bar"' .
PATH_SEPARATOR.
get_incude_path());It may add some complexity in the parser but it can be really
useful (well, for phar-like applications at least as I would
not recommend too use that in normal apps :).Cheers,
Hi Dmitry,
It is too difficult for extension that is not in the core distribution
yet.
For now I think it is simple to override zend_stream_open_function() and
zend_resolve_path_function() callbacks by ext/phar and provide something
like phar.include_path directive.
It is indeed a solution. But my point was to support quotes in the
include_path, no matter if an extension needs it or not. However it is
not that critical and nobody has complained about this problem before
:)
--
Pierre
http://blog.thepimp.net | http://www.libgd.org
Pierre Joye wrote:
Hi Dmitry,
It is too difficult for extension that is not in the core distribution
yet.
For now I think it is simple to override zend_stream_open_function() and
zend_resolve_path_function() callbacks by ext/phar and provide something
like phar.include_path directive.It is indeed a solution. But my point was to support quotes in the
include_path, no matter if an extension needs it or not. However it is
not that critical and nobody has complained about this problem before
Actually, this feature was requested several times (and immediately
dismissed) about 2 years ago, first by Francois Laupretre, I think, but
I've heard it requested many times. Until I realized how easy it is to
implement, I was actually against this kind of thing. I strongly
encourage those who have the impulse to dismiss the patch to actually
try it. For no performance hit, it adds big functionality to PHP.
To be ultra-clear, the patch is not phar-specific.
Greg