Dropping ze1_compatibility_mode (PHP 5.3)

17 years ago by Felipe Pena — view source

unread

Hello!

I've backported the Dmitry's patch (HEAD) for to drop
zend.ze1_compatibility_mode in PHP_5_3 branch. Would be interesting
remove it in 5_3? :)

Here's the patch:
http://felipe.ath.cx/diff/drop-ze1.diff

Tests to be removed:
/ZendEngine2/tests bug30332.phpt bug31828.phpt bug32080.phpt
bug32852.phpt bug33243.phpt bug34712.phpt
bug34767.phpt
/php-src/tests/lang bug22367.phpt

--
Regards,
Felipe Pena.

17 years ago by Cristian Rodriguez — view source

unread

2008/3/10, Felipe Pena felipensp@gmail.com:

Hello!

I've backported the Dmitry's patch (HEAD) for to drop
zend.ze1_compatibility_mode in PHP_5_3 branch. Would be interesting
remove it in 5_3? :)

+1 , because this feature does not work, so there is no point to keep
it anymore.

--
"If debugging is the process of removing bugs, then programming must
be the process of putting them in." – Edsger Dijkstra

http://www.cristianrodriguez.net

17 years ago by Felipe Pena — view source

unread

Hallo developers,

Have we a decision?

2008/3/11, Cristian Rodriguez judas.iscariote@gmail.com:

2008/3/10, Felipe Pena felipensp@gmail.com:

Hello!

I've backported the Dmitry's patch (HEAD) for to drop
zend.ze1_compatibility_mode in PHP_5_3 branch. Would be interesting
remove it in 5_3? :)

+1 , because this feature does not work, so there is no point to keep
it anymore.

--
"If debugging is the process of removing bugs, then programming must
be the process of putting them in." – Edsger Dijkstra

http://www.cristianrodriguez.net

17 years ago by Xuefer — view source

unread

Drop it.

Dmitry.
php5/ext/pdo/pdo_dbh.c:1530: error: 'zend_executor_globals' has no
member named 'ze1_compatibility_mode'
sorry for the noise again, who's responsive to extension relatived to
this change?
there're more if you grep the source, even in tests. thanks

17 years ago by Antony Dovgal — view source

unread

php5/ext/pdo/pdo_dbh.c:1530: error: 'zend_executor_globals' has no
member named 'ze1_compatibility_mode'

Fixed, check it out again.

sorry for the noise again, who's responsive to extension relatived to
this change?
there're more if you grep the source, even in tests.

Not anymore =)

--
Wbr,
Antony Dovgal