Hi all
Rob Nicholson and I have made a set updates the QA pages, mainly based
on things that we've learned over the past
year of test case writing - we had a lot of input from Raghu and Marcus
on this too of course.
The updated pages are here for review: http://zapt.info/phpt/write-test.php.
Feedback welcome!
Zoe Slattery
zoe wrote:
Feedback welcome!
Some minor grammar picks:
though all the tests currently written are NOT in there
Try: "though not all the tests currently written are in there"
more - although - these
Inappropriate use of dashes: use commas, although in this case, the
comma after although is not necessary. :-)
If you want more guidance than that - you can always ask
Same goes here.
Intentionally generating an error is allowed, or even encouraged.
Try "Intentionally generating an error is allowed and encouraged."
Often you want to run test scripts without run-tests.php by simply
executing them on command line like any other php script.
Out of curiosity, I'm wondering why run-tests.php itself can't run a
test file by itself.
--
Edward Z. Yang GnuPG: 0x869C48DA
HTML Purifier http://htmlpurifier.org Anti-XSS Filter
[[ 3FA8 E9A9 7385 B691 A6FC B3CB A933 BE7D 869C 48DA ]]
Edward Z. Yang wrote:
Some minor grammar picks:
Thanks - all fixed.
Out of curiosity, I'm wondering why run-tests.php itself can't run a
test file by itself.
It can - in fact that's exactly what it does, run .phpt files. However,
sometimes easier and quicker when you are writing the test to run it as
a PHP script and look at the output on the screen.
Zoe
Rob Nicholson and I have made a set updates the QA pages, mainly
based on things that we've learned over the past
year of test case writing - we had a lot of input from Raghu and
Marcus on this too of course.The updated pages are here for review: http://zapt.info/phpt/write-
test.php.
Greetings Zoe-
A few moons ago the following [rough] wiki page was started with the
aim to answer questions not yet covered within the QA site, questions
like "installing lcov", "how to test if a test covers what I want",
and such. Please feel free to steal information from it for qaweb:
http://doc.php.net/wiki/writing-tests
Regarding your proposed changes, could you provide a unified diff?
Looks good, but it's difficult to see what's been updated. Or, just
commit... :)
Regards,
Philip
Philip Olson wrote:
A few moons ago the following [rough] wiki page was started with the
aim to answer questions not yet covered within the QA site, questions
like "installing lcov", "how to test if a test covers what I want",
and such. Please feel free to steal information from it for qaweb:http://doc.php.net/wiki/writing-tests
For now, I have put a link in the QA web pages that points to this. I
think the QA pages could probably do with a bit of restructuring to make
them easier to navigate and at that stage this information should go in,
it's very useful. I have restructuring on my long term to-do list - so
I'd be more than happy if someone else got there first :-)Regarding your proposed changes, could you provide a unified diff?
Looks good, but it's difficult to see what's been updated. Or, just
commit... :)
If there isn't any further feedback by this time tomorrow I'll commit.
Thanks for your help,
Zoe