CLI SAPI/PHP Changes

18 years ago by Andrew Rose — view source — reply

unread

I'm looking into making a few changes to the PHP session code in
respect to the CLI SAPI. But before I did, I wanted to see if the
changes (patch) would be excepted (I really hate wasting my time).
The changes are as such:

Update the session code to suppress "headers already sent" warnings
when running via the CLI SAPI.
Update the session_set_save_handler() functionality to persist past
session_destroy() ready for another session_start(). Maybe via a
flag?

From what I have gathered, the CLI SAPI silently ignores headers, so
the fact is throws warnings seems superfluous. The session handler
persisting past a session_destroy() I'm just not sure about, so would
appreciate any heads up / advice.

Both points have workarounds, but it would be nice to not have to
workaround them.

Anyway, would these changes likely be accepted?

cheers
Andrew Rose

18 years ago by Brian Zablocky — view source — reply

unread

Andrew Rose wrote:

Hi

I'm looking into making a few changes to the PHP session code in
respect to the CLI SAPI. But before I did, I wanted to see if the
changes (patch) would be excepted (I really hate wasting my time).
The changes are as such:

Update the session code to suppress "headers already sent" warnings
when running via the CLI SAPI.

Update the session_set_save_handler() functionality to persist past
session_destroy() ready for another session_start(). Maybe via a
flag?

From what I have gathered, the CLI SAPI silently ignores headers, so
the fact is throws warnings seems superfluous. The session handler
persisting past a session_destroy() I'm just not sure about, so would
appreciate any heads up / advice.

Both points have workarounds, but it would be nice to not have to
workaround them.

Anyway, would these changes likely be accepted?

cheers
Andrew Rose

I obviously can't speak for the php team, but I have personally experienced
item 1 and have had to code around it.

I have no experience with item 2.

--Brian Z

18 years ago by Brian Zablocky — view source — reply

unread

Andrew Rose wrote:

Hi

I'm looking into making a few changes to the PHP session code in
respect to the CLI SAPI. But before I did, I wanted to see if the
changes (patch) would be excepted (I really hate wasting my time).
The changes are as such:

Update the session code to suppress "headers already sent" warnings
when running via the CLI SAPI.

Update the session_set_save_handler() functionality to persist past
session_destroy() ready for another session_start(). Maybe via a
flag?

From what I have gathered, the CLI SAPI silently ignores headers, so
the fact is throws warnings seems superfluous. The session handler
persisting past a session_destroy() I'm just not sure about, so would
appreciate any heads up / advice.

Both points have workarounds, but it would be nice to not have to
workaround them.

Anyway, would these changes likely be accepted?

cheers
Andrew Rose

I obviously can't speak for the php team, but I have personally experienced
item 1 and have had to code around it.

I have no experience with item 2.

--Brian Z