Here are the diffs Rasmus asked for on the three internal files that the
internals group would be concerned about (main/php.h, main/main.c,
main/rfc1867.c). These diffs were done on 4.3.2 code. If you all feel
this is worthy of inclusion, I can construct a CVS diff as directed by
README.SUBMITTING_PATCH as well as submit the five associated functions
as a PEAR module to the PEAR group.
There seems to be quite a bit of demand for this functionality. When I
first researched this functionality, there were numerous discussions in
PHP forums with many people wanting a file upload status bar. I have
also received several emails from people who saw my post and are dying
to a source patch, but I couldn't give them one because I didn't have it
working with 4.3.2 yet. So it seems to me that there is quite a bit of
demand to add this feature.
Here are some questions I have:
- Will you want to use #ifdef with this additional code?
- Is there a security risk since I am taking the value of the uploaded
hidden ID and appending it as part of a filename? If so, what do you
recommend I do to fix that problem? - Are there any other changes you would like me to make?
I can give a working URL that demonstrates this process to those who
email me and ask. I just don't want to broadcast it to the public list.
:-)
--David
We're not interested in the Javascript or HTML parts of this
stuff, but if
you could post a diff of the changes you made to the core
file upload code
to implement the status functions we can take a look. The
Javascript and
HTML that makes use of these hooks fit better as a PEAR module.-Rasmus
-----=+=-----
David Enderson
Programmer
Digital IMS
402.437.0137
denderson@digitalims.com