PHP6 - rar extension

18 years ago by BuildSmart — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've fixed the rar extension, was a no-brainer, a one-line change,
not worthy of a patch file.

@ -628,7 +628,7 @
/* {{{ rar_functions[]

-function_entry rar_functions[] = {
+zend_function_entry rar_functions[] = {
PHP_FE(rar_open, NULL)
PHP_FE(rar_list, NULL)
PHP_FE(rar_entry_get, NULL)
-- BuildSmart

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1jZO0hzWbkf0eKgRAntaAJ0USGFs8mWpDZViykUZiwIx/mVyOgCfeEYc
toF9N9VjiK0uQRVio9S0dKM=
=4Orv
-----END PGP SIGNATURE

18 years ago by BuildSmart — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've fixed the rar extension, was a no-brainer, a one-line change,
not worthy of a patch file.

@ -628,7 +628,7 @
/* {{{ rar_functions[]

*/

-function_entry rar_functions[] = {
+zend_function_entry rar_functions[] = {
PHP_FE(rar_open, NULL)
PHP_FE(rar_list, NULL)
PHP_FE(rar_entry_get, NULL)

-- BuildSmart

Spoke too soon, while it builds with wanring it doesn't function
properly and segfaults so I need to look at it a little closer.

-- BuildSmart

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1kFr0hzWbkf0eKgRAkrXAKDchoZeVNjEzuMUHBkK8OcAPYv3CACfdYEA
8NCMojpzaaciknqteEjDLBA=
=6mHL
-----END PGP SIGNATURE

18 years ago by Pierre — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've fixed the rar extension, was a no-brainer, a one-line change,
not worthy of a patch file.

@ -628,7 +628,7 @
/* {{{ rar_functions[]

*/

-function_entry rar_functions[] = {
+zend_function_entry rar_functions[] = {
PHP_FE(rar_open, NULL)
PHP_FE(rar_list, NULL)
PHP_FE(rar_entry_get, NULL)

-- BuildSmart

Spoke too soon, while it builds with wanring it doesn't function
properly and segfaults so I need to look at it a little closer.

Tony reads this list however I would suggest to use the right place to
post patch or report bugs:

http://pecl.php.net/package/rar to report a bug for the rar package.
http://pecl.php.net/support.php for the pecl-dev mailing list

Using the issues tracker will ensure that your patch will not get lost.

Cheers,
--Pierre

18 years ago by Antony Dovgal — view source — reply

unread

What was the problem again?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've fixed the rar extension, was a no-brainer, a one-line change,
not worthy of a patch file.

@ -628,7 +628,7 @
/* {{{ rar_functions[]

*/

-function_entry rar_functions[] = {
+zend_function_entry rar_functions[] = {
PHP_FE(rar_open, NULL)
PHP_FE(rar_list, NULL)
PHP_FE(rar_entry_get, NULL)

-- BuildSmart

Spoke too soon, while it builds with wanring it doesn't function
properly and segfaults so I need to look at it a little closer.

Tony reads this list however I would suggest to use the right place to
post patch or report bugs:

http://pecl.php.net/package/rar to report a bug for the rar package.
http://pecl.php.net/support.php for the pecl-dev mailing list

Using the issues tracker will ensure that your patch will not get lost.

Cheers,
--Pierre

--
Wbr,
Antony Dovgal

18 years ago by Antony Dovgal — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

/php-src/ext/rar/rar.cpp: In function 'int zm_startup_rar(int, int)':
/php-src/ext/rar/rar.cpp:677: error: invalid conversion from 'void*'
to 'UChar*'

ext/rar/rar.cpp:
673:PHP_MINIT_FUNCTION(rar)
674:{
675: zend_class_entry rar_class_entry;
676:
677: INIT_CLASS_ENTRY(rar_class_entry, "RarEntry", rar_functions);
678: rar_class_entry_ptr = zend_register_internal_class
(&rar_class_entry TSRMLS_CC);

And you fixed it by changing "function_entry" to "zend_function_entry"?
Well, then your compiler went mad.

Because they are absolutely equal:
main/php, line 177
#define function_entry zend_function_entry

--
Wbr,
Antony Dovgal

18 years ago by Antony Dovgal — view source — reply

unread

cvs up both HEAD and PECL/rar, I fixed the build.

There were two separate problems:
http://news.php.net/php.zend-engine.cvs/5979
http://news.php.net/php.pecl.cvs/8490

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

/php-src/ext/rar/rar.cpp: In function 'int zm_startup_rar(int, int)':
/php-src/ext/rar/rar.cpp:677: error: invalid conversion from 'void*'
to 'UChar*'

ext/rar/rar.cpp:
673:PHP_MINIT_FUNCTION(rar)
674:{
675: zend_class_entry rar_class_entry;
676:
677: INIT_CLASS_ENTRY(rar_class_entry, "RarEntry", rar_functions);
678: rar_class_entry_ptr = zend_register_internal_class
(&rar_class_entry TSRMLS_CC);

And you fixed it by changing "function_entry" to "zend_function_entry"?
Well, then your compiler went mad.

Because they are absolutely equal:
main/php, line 177
#define function_entry zend_function_entry

--
Wbr,
Antony Dovgal

18 years ago by BuildSmart — view source — reply

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yeah, I had just built something else using gcc 2.95 and forgot to
switch back to 4.0, it sailed through giving it a warning and not an
error.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

/php-src/ext/rar/rar.cpp: In function 'int zm_startup_rar(int, int)':
/php-src/ext/rar/rar.cpp:677: error: invalid conversion from 'void*'
to 'UChar*'

ext/rar/rar.cpp:
673:PHP_MINIT_FUNCTION(rar)
674:{
675: zend_class_entry rar_class_entry;
676:
677: INIT_CLASS_ENTRY(rar_class_entry, "RarEntry", rar_functions);
678: rar_class_entry_ptr = zend_register_internal_class
(&rar_class_entry TSRMLS_CC);

And you fixed it by changing "function_entry" to
"zend_function_entry"?
Well, then your compiler went mad.

Because they are absolutely equal:
main/php, line 177
#define function_entry zend_function_entry

--
Wbr,
Antony Dovgal

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1xS30hzWbkf0eKgRAhqjAJwJg6mwjOIbutddcDTbOt4RNi3chgCgv+Zy
rHjYQJRyxvq5/+RAdgOx9eE=
=PuSg
-----END PGP SIGNATURE