Hello all,
i am doing some unicode stuff and missng a few things and found a
few issues:
-
ZVAL_STRL() is inconsistent with the rest of the ZVAL_*L().
The former has order: zval, zstr, len, type, flags
while the others have the order: zval, value, len, flags
Since a zstr value is defined by the string and the type the
order should be: zval, zstr, type, len, flagsI discussed this with Andrei and will commit in a bit.
-
zend_call_methods has no zend_u_call_method version, see patch
-
parameter parsing doesn't allow to receive a string in current
run-time setting. I will introduce a new parameter parsing option
'x' that gets replaced by either 's' or 'u' depending on UG(unicode).
This is pretty useful inside spl, pdo, reflection and anything else
that deals with functions, classes, ..., see patch
Comments?
Best regards,
Marcus
- zend_call_methods has no zend_u_call_method version, see patch
Good catch.
- parameter parsing doesn't allow to receive a string in current
run-time setting. I will introduce a new parameter parsing option
'x' that gets replaced by either 's' or 'u' depending on UG(unicode).
This is pretty useful inside spl, pdo, reflection and anything else
that deals with functions, classes, ..., see patchComments?
This is fine with me.
-Andrei