Hi,
Here are patches to use Brian Shire's optimizations (applied by Ilia to 5.2 the other day) in a couple more places, and for HEAD. In Unicode mode, concat_function() is up to 20%+ faster! (Probably because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so much with non-ZTS I guess.)
Also removed a few strlen() calls that I noticed when looking at is_numeric_string's usage awhile ago. :-)
http://realplain.com/php/misc_optimizations.diff
http://realplain.com/php/misc_optimizations_5_2.diff
Matt
Matt,
The ext/* patches were applied to 5.2, I'll commit the Zend/ ones
once we have an agreement on the previous patch.
Hi,
Here are patches to use Brian Shire's optimizations (applied by
Ilia to 5.2 the other day) in a couple more places, and for HEAD.
In Unicode mode, concat_function() is up to 20%+ faster! (Probably
because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so
much with non-ZTS I guess.)Also removed a few
strlen()calls that I noticed when looking at
is_numeric_string's usage awhile ago. :-)http://realplain.com/php/misc_optimizations.diff
http://realplain.com/php/misc_optimizations_5_2.diffMatt
Ilia Alshanetsky
Which previous patch? From Matt?
-Andrei
Matt,
The ext/* patches were applied to 5.2, I'll commit the Zend/ ones once
we have an agreement on the previous patch.Hi,
Here are patches to use Brian Shire's optimizations (applied by Ilia
to 5.2 the other day) in a couple more places, and for HEAD. In
Unicode mode, concat_function() is up to 20%+ faster! (Probably
because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so much
with non-ZTS I guess.)Also removed a few
strlen()calls that I noticed when looking at
is_numeric_string's usage awhile ago. :-)http://realplain.com/php/misc_optimizations.diff
http://realplain.com/php/misc_optimizations_5_2.diffMatt
Ilia Alshanetsky
Which previous patch? From Matt?
The one for is_numeric_string()
Ilia Alshanetsky