pushing some more optimization patches

19 years ago by Nuno Lopes — view source — reply

unread

Hi,

I would like to push 2 more optimization patches onto the PHP tree:

make arginfo const (and save memory):
http://mega.ist.utl.pt/~ncpl/zend_arginfo_const.txt (for php 5.2.1)
Trivial patch, which is expecially good for multi-core systems sharing the
same cache.
use -fvisibility when using gcc 4:
http://mega.ist.utl.pt/~ncpl/php_gcc4_visibility.txt (for php 5.3/6)
this is a trickier patch and needs some tweaking in extensions exporting
their own API. The little hacks in the Apache SAPIs are needed because older
apache versions didn't know anything about gcc 4.

Any opinions or any volunteer to commit those patches? :)

Thanks,
Nuno

19 years ago by Ilia Alshanetsky — view source — reply

unread

I would like to push 2 more optimization patches onto the PHP tree:

make arginfo const (and save memory): http://mega.ist.utl.pt/
~ncpl/zend_arginfo_const.txt (for php 5.2.1)
Trivial patch, which is expecially good for multi-core systems
sharing the same cache.

The first part looks fine, and if no one objects I'll commit it next
week.

use -fvisibility when using gcc 4: http://mega.ist.utl.pt/~ncpl/
php_gcc4_visibility.txt (for php 5.3/6)
this is a trickier patch and needs some tweaking in extensions
exporting their own API. The little hacks in the Apache SAPIs are
needed because older apache versions didn't know anything about gcc 4.

I'd prefer to hold off on adding to 5.2 series at this time, lets try
it out on 6.0 and if it works fine there perhaps port it back once
5.3 is on the table.

Ilia Alshanetsky

19 years ago by Nuno Lopes — view source — reply

unread

I would like to push 2 more optimization patches onto the PHP tree:

make arginfo const (and save memory): http://mega.ist.utl.pt/
~ncpl/zend_arginfo_const.txt (for php 5.2.1)
Trivial patch, which is expecially good for multi-core systems sharing
the same cache.

The first part looks fine, and if no one objects I'll commit it next
week.

OK, thanks.

use -fvisibility when using gcc 4: http://mega.ist.utl.pt/~ncpl/
php_gcc4_visibility.txt (for php 5.3/6)
this is a trickier patch and needs some tweaking in extensions exporting
their own API. The little hacks in the Apache SAPIs are needed because
older apache versions didn't know anything about gcc 4.

I'd prefer to hold off on adding to 5.2 series at this time, lets try it
out on 6.0 and if it works fine there perhaps port it back once 5.3 is on
the table.

Sure. I didn't meant to push it to 5.2 as it can break some extensions
(although the fix is trivial).

Nuno

19 years ago by Andi Gutmans — view source — reply

unread

The arginfo patch looks OK to me. Not sure about the visibility patch. I'll
try and look into it tomorrow.

-----Original Message-----
From: Nuno Lopes [mailto:nlopess@php.net]
Sent: Thursday, November 09, 2006 9:09 AM
To: PHPdev
Subject: [PHP-DEV] pushing some more optimization patches

Hi,

I would like to push 2 more optimization patches onto the PHP tree:

make arginfo const (and save memory):
http://mega.ist.utl.pt/~ncpl/zend_arginfo_const.txt (for php
5.2.1) Trivial patch, which is expecially good for multi-core
systems sharing the same cache.

use -fvisibility when using gcc 4:
http://mega.ist.utl.pt/~ncpl/php_gcc4_visibility.txt (for php
5.3/6) this is a trickier patch and needs some tweaking in
extensions exporting their own API. The little hacks in the
Apache SAPIs are needed because older apache versions didn't
know anything about gcc 4.

Any opinions or any volunteer to commit those patches? :)

Thanks,
Nuno

--
To
unsubscribe, visit: http://www.php.net/unsub.php