PCRE error handling patch

19 years ago by Andrei Zmievski — view source

unread

I made a patch (against HEAD currently only) that makes it possible to
set runtime limits on backtracking and recursion. It also implements
preg_last_error() that lets users check whether there was an execution
error (such as limit exceeded or bad UTF-8 or whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Jani Taskinen — view source

unread

 Sounds to me like a bug fix..all those recursion bugs in the db.. :)

 --Jani

I made a patch (against HEAD currently only) that makes it possible to set
runtime limits on backtracking and recursion. It also implements
preg_last_error() that lets users check whether there was an execution error
(such as limit exceeded or bad UTF-8 or whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Nuno Lopes — view source

unread

I would say that 100.000 recursions is too much. When I made my patch it was
segfaulting with such value. 50.000 is a much safer choice (at least on my
gentoo box, 8 MB of stack).

Nuno

----- Original Message -----

I made a patch (against HEAD currently only) that makes it possible to set
runtime limits on backtracking and recursion. It also implements
preg_last_error() that lets users check whether there was an execution
error (such as limit exceeded or bad UTF-8 or whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Andrei Zmievski — view source

unread

It's hard to pick a default that will work for everyone. I can probably
see setting recursion limit somewhat lower than backtracking one,
though. Maybe 100,000/50,000 or something like that.

-Andrei

I would say that 100.000 recursions is too much. When I made my patch
it was segfaulting with such value. 50.000 is a much safer choice (at
least on my gentoo box, 8 MB of stack).

Nuno

----- Original Message -----

I made a patch (against HEAD currently only) that makes it possible
to set runtime limits on backtracking and recursion. It also
implements preg_last_error() that lets users check whether there was
an execution error (such as limit exceeded or bad UTF-8 or whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Ilia Alshanetsky — view source

unread

No, lets wait with it till the next PHP 5 release.

Ilia

I made a patch (against HEAD currently only) that makes it possible
to set runtime limits on backtracking and recursion. It also
implements preg_last_error() that lets users check whether there
was an execution error (such as limit exceeded or bad UTF-8 or
whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Andrei Zmievski — view source

unread

5.1.4?

-Andrei

No, lets wait with it till the next PHP 5 release.

Ilia

I made a patch (against HEAD currently only) that makes it
possible to set runtime limits on backtracking and recursion. It
also implements preg_last_error() that lets users check whether
there was an execution error (such as limit exceeded or bad UTF-8
or whatever).

Ilia, do you think it might make it into 5.1.3?

http://www.php.net/~andrei/pcre.diff

-Andrei

19 years ago by Lukas Smith — view source

unread

Andrei Zmievski wrote:

5.1.4?

I have the following items as future todos:

1.  new functions: ext/date: date_sun_info (derick)
2. Switch for disabling/enabling materialized cursors in mysqli (georg)
3. fix __toString() (marcus)
4. add support for files >2GB (wez)
5. Add input filter extension via a symlink from pecl into core as

experimental (derick)
6. Add json extension via a symlink from pecl into core as experimental
7. add PDO::defaultFetchMode attribute (pierre)
8. PCRE: make it possible to set runtime limits on backtracking and
recursion and add preg_last_error()

Especially for Nr. 3 I guess we would have to move to 5.2.
That is why I would favor 5.2 over 5.1.4 and reserve 5.1.4 to a quick
security fix release if one becomes necessary.

regards,
Lukas

19 years ago by Jani Taskinen — view source

unread

Andrei Zmievski wrote:

5.1.4?

I have the following items as future todos:

new functions: ext/date: date_sun_info (derick)

Switch for disabling/enabling materialized cursors in mysqli (georg)

fix __toString() (marcus)

 Wasn't that fixed already? Or was that just in HEAD?

add support for files >2GB (wez)

Add input filter extension via a symlink from pecl into core as
experimental (derick)

Add json extension via a symlink from pecl into core as experimental

add PDO::defaultFetchMode attribute (pierre)

PCRE: make it possible to set runtime limits on backtracking and
recursion and add preg_last_error()

Especially for Nr. 3 I guess we would have to move to 5.2.
That is why I would favor 5.2 over 5.1.4 and reserve 5.1.4 to a quick security
fix release if one becomes necessary.

 I could not agree more. +1 for 5.2. We can't wait for 6.0 forever to get
 some new features in. It's still at least year from now til it's release
 I bet.

 --Jani

19 years ago by Andrei Zmievski — view source

unread

The problem is that with 5.2 you'll get all kinds of old threads
resurrected, because people think that it's time to add some new
features.. Like namespaces.

-Andrei

I could not agree more. +1 for 5.2. We can't wait for 6.0 forever 
to get
some new features in. It's still at least year from now til it's
release
I bet.

19 years ago by Jani Taskinen — view source

unread

 I have this thing called "delete" in my MUA which I can use to get rid
 of unwanted noise. :)

 --Jani

The problem is that with 5.2 you'll get all kinds of old threads resurrected,
because people think that it's time to add some new features.. Like
namespaces.

-Andrei
I could not agree more. +1 for 5.2. We can't wait for 6.0 forever to get
some new features in. It's still at least year from now til it's release
I bet.

--
Give me your money at @ http://pecl.php.net/wishlist.php/sniper
Donating money may make me happier and friendlier for a limited period!
Death to all 4 letter abbreviations starting with P!

19 years ago by Marcus Boerger — view source

unread

Hello Andrei,

no namespaces in 5.2 (.) that is for head.

Wednesday, April 12, 2006, 8:01:41 PM, you wrote:

The problem is that with 5.2 you'll get all kinds of old threads
resurrected, because people think that it's time to add some new
features.. Like namespaces.

-Andrei

I could not agree more. +1 for 5.2. We can't wait for 6.0 forever 
to get
some new features in. It's still at least year from now til it's
release
I bet.

Best regards,
Marcus

19 years ago by Marcus Boerger — view source

unread

Hello Lukas,

Wednesday, April 12, 2006, 6:17:13 PM, you wrote:

Andrei Zmievski wrote:

5.1.4?

I have the following items as future todos:

1.  new functions: ext/date: date_sun_info (derick)
2. Switch for disabling/enabling materialized cursors in mysqli (georg)
3. fix __toString() (marcus)

fixed in head, will be in 5.2

4. add support for files >2GB (wez)
5. Add input filter extension via a symlink from pecl into core as 
experimental (derick)
6. Add json extension via a symlink from pecl into core as experimental
7. add PDO::defaultFetchMode attribute (pierre)
s/pierre/marcus/; fixed in head will be in 5.2
8. PCRE: make it possible to set runtime limits on backtracking and
recursion and add preg_last_error()

Most of the other stuff is either bigger feature additions or requires api
changes so i'd say all of them in 5.2.

regards
marcus