I agree +1
At 00:00 20.05.2003 -0700, you wrote:
I don't mean to start a big thread here - I feel very uncomfortable
releasing such a sensitive patch with so little testing, and don't
exactly
understand why the problem that it addresses is suddenly so urgent. If
there's consensus here that this patch is important for this 4.3.x
release,
so be it - I want to at least voice my opinion before it gets finalized.I have the same feelings, I was not really happy by putting it in in the
PHP_4_3 either. (Though I'm not sure if I voiced that opinion on a
list). I think it's up to our release guy (Jani) to decide what to do
with it.My only reservation is that it went in somewhat late in the RC cycle.
This change has been needed for quite a while. I know the issue itself
has been around for quite a while, but threaded web servers have become
much more common on Solaris in recent months and problems in our nsapi api
have been worked out so PHP is now a viable iPlanet plugin. This was
never really the case before. However, the last hurdle for decent iPlanet
support is this patch.The second reason is performance. By moving away from stdio streams we
save astat()call for every single file open. Believe me, disk-touching
syscalls is a killer.And finally, there has been wide support for testing this thing to death.
We are definitely putting it through the ringer at Yahoo (hence the patch
from Brian). It is running on php.net and Sascha has been pounding it as
well. There may very well still be issues, but with a bit of dedicated
testing, the performance benefits plus finally having real iPlanet support
is worth a little extra pain as far as I am concerned.-Rasmus