Just realized there is an issue with URI handling and XML.
Problem deals with escaping and non-filesystem URIs. Doesn't work unless
URI gets double escaped.
Have a patch that's only been tested a bit with latest libxml so far,
though I dont forsee any issues with earlier versions.
http://www.ctindustries.net/patches/libxml.diff.txt
The issue is it may break existing apps that double escape only the
arguments and not the entire URI. It will though make it work like the
rest of the stream based functions like file_get_contents, but still
allow the loading of a URI that has been completely escaped, which the
other functions fail on but worked for xml under PHP 5.0.
I'm out for the week as of tomorrow morning but would like to get some
fix in for 5.1. Should I commit now to get it into RC1, wait till I get
back and do more testing first, or not do it since it potentially will
break some apps. Personally I think what it fixes greatly outweighs any
potential breakage.
Rob
Rob, hi,
You never committed this (or anything else in ext/libxml since then as far
as I can see) - do you still intend to?
- Steph-working-on-backlog-and-will-shoot-the-next-person-to-ask
----- Original Message -----
From: "Rob Richards" rrichards@ctindustries.net
To: internals@lists.php.net
Sent: Sunday, August 07, 2005 4:06 PM
Subject: [PHP-DEV] XML URIs and streams
Just realized there is an issue with URI handling and XML.
Problem deals with escaping and non-filesystem URIs. Doesn't work unless
URI gets double escaped.Have a patch that's only been tested a bit with latest libxml so far,
though I dont forsee any issues with earlier versions.
http://www.ctindustries.net/patches/libxml.diff.txtThe issue is it may break existing apps that double escape only the
arguments and not the entire URI. It will though make it work like the
rest of the stream based functions like file_get_contents, but still
allow the loading of a URI that has been completely escaped, which the
other functions fail on but worked for xml under PHP 5.0.I'm out for the week as of tomorrow morning but would like to get some
fix in for 5.1. Should I commit now to get it into RC1, wait till I get
back and do more testing first, or not do it since it potentially will
break some apps. Personally I think what it fixes greatly outweighs any
potential breakage.Rob
Thanks for the reminder Steph. Had slipped my mind. finally commited.
Rob
Steph wrote:
Rob, hi,
You never committed this (or anything else in ext/libxml since then as far
as I can see) - do you still intend to?
- Steph-working-on-backlog-and-will-shoot-the-next-person-to-ask