I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?
http://www.trachtenberg.com/patches/soap_error_handler.txt
Thanks.
-adam
--
adam@trachtenberg.com | http://www.trachtenberg.com
author of o'reilly's "upgrading to php 5" and "php cookbook"
avoid the holiday rush, buy your copies today!
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:
I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?
Are you sure that moving TSRMLS_FETCH() at the end of all declarations doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS enabled).
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?Are you sure that moving TSRMLS_FETCH() at the end of all declarations doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS enabled).
That could be okay. I wasn't sure how TSRMLS_FETCH() effected the EG()
and CG() macros.
FWIW, I am using "gcc version 2.95.4 20011002 (Debian prerelease)".
-adam
--
adam@trachtenberg.com | http://www.trachtenberg.com
author of o'reilly's "upgrading to php 5" and "php cookbook"
avoid the holiday rush, buy your copies today!
On Wed, 11 May 2005 15:57:54 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?Are you sure that moving TSRMLS_FETCH() at the end of all declarations doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS enabled).That could be okay. I wasn't sure how TSRMLS_FETCH() effected the EG()
and CG() macros.FWIW, I am using "gcc version 2.95.4 20011002 (Debian prerelease)".
Please try next snapshot (or update your local CVS repository), I committed the patch few seconds ago.
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com
Antony,
i've had a similar issue with extensions i've written. i get
"Undeclared identifer" problems under VS.NET if TSRMLS_FETCH() does not
appear after all other declarations.
l0t3k
"Antony Dovgal" antony@zend.com wrote in message
news:20050511231817.08022b66.antony@zend.com...
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?Are you sure that moving TSRMLS_FETCH() at the end of all declarations
doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS
enabled).--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com
Antony Dovgal wrote:
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?Are you sure that moving TSRMLS_FETCH() at the end of all declarations doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS enabled).
Yes, just moving it to the end solves it on my old FreeBSD box.
-Rasmus
Ok, now I cant build under windows with that change.
Rob
Antony Dovgal wrote:
On Wed, 11 May 2005 13:56:46 -0400 (EDT)
Adam Maccabee Trachtenberg adam@trachtenberg.com wrote:I'm getting a parse error with ext/soap in HEAD. This patch seems to
fix my problem. Can someone review and apply?Are you sure that moving TSRMLS_FETCH() at the end of all declarations doesn't help?
What compiler are you using? (gcc-3.3.4 works fine, with and without ZTS enabled).
On Wed, 11 May 2005 17:08:40 -0400
Rob Richards rrichards@ctindustries.net wrote:
Ok, now I cant build under windows with that change.
Ok, fixed.
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com