looks good.

thanks, grant

-----Original Message-----
From: Jani Taskinen [mailto:sniper@iki.fi]
Sent: 26 March 2005 03:20
To: Croker, Grant
Cc: internals@lists.php.net
Subject: RE: [PHP-DEV] [PATCH] Bug #32333 - Unable to perform command
linebuild with Ingres extension

 It should work now, please test.

 --Jani

Modified patch applied. No need to patch php_ii.h.

--Jani

the config.w32 in cvs does not work - running 'cscript /nologo
configure.js --with-ingres' (after running buildconf) generates the
following:

Checking for iiapi.h ... C:\Ingres[GC]\ingres\files
Checking for library iilibapi.lib ...
........\Ingres[GC]\ingres\lib\iilibapi
.lib
C:\src\php\main\php-src\configure.js(986, 3) Microsoft JScript
runtime
error: 'PHP_INGRES_II_SHARED' is undefined

the patch at the bottom corrects this, but building PHP fails with:

internal_functions.c
main\internal_functions.c(54) : error C2065: 'phpext_ingres_ptr' :
undeclared identifier
main\internal_functions.c(54) : error C2099: initializer is not a
constant
NMAKE : fatal error U1077: '"cl.exe"' : return code '0x2'
Stop.

the php_ingres.h in my original mail fixes this. At the moment the
build
/configure process for windows and UNIX need bringing in to line.
Until
then this kludge is needed.

grant

----start-----
Index: ext/ingres_ii/config.w32

RCS file: /repository/php-src/ext/ingres_ii/config.w32,v
retrieving revision 1.1
diff -u -b -w -B -d -r1.1 config.w32
--- ext/ingres_ii/config.w32 18 Mar 2005 23:24:14 -0000
1.1
+++ ext/ingres_ii/config.w32 21 Mar 2005 10:47:18 -0000
@@ -13,7 +13,7 @@
if (CHECK_HEADER_ADD_INCLUDE("iiapi.h",
"CFLAGS_INGRES", ii_system + "\ingres\files;" + PHP_INGRES) &&
CHECK_LIB("iilibapi.lib", "ingres",
ii_system + "\ingres\lib;" + PHP_INGRES)) {
AC_DEFINE('HAVE_II', 1);

•   		EXTENSION("ingres_ii","ii.c");
  

•   		EXTENSION("ingres","ii.c");
    	} else {
    		// ingres is missing files
    		WARNING("Ingres not enabled; libraries
  

and headers not found in " + ii_system);
-------end