xml_parser_create patch

Hi,

I'd like to submit a small patch that allows xml_parser_create
and xml_parser_create_ns (Expat version) to honor the encoding of
an XML document (including UTF-16). This solves bug #23293. With this
patch xml_parser_create now works identical to the libxml2 version of it
(AFAIK).

Note that this patch may break applications that assumes
ISO-8859-1 (or default encoding) for XML applications, but only
if the application omitted a desired encoding for xml_parser_create.

Applications that wish their XML parser to do decoding
but want a specific target encoding can use option
XML_OPTION_TARGET_ENCODING .

-- Adam

--
Adam Dickmeiss mailto:adam@indexdata.dk http://www.indexdata.dk
Index Data T: +45 33410100 Mob.: 212 212 66

Adam Dickmeiss adam@indexdata.dk wrote:

-1 for the patch if it doesn't have a default value for the encoding.

We don't want to break BC again.
I respect that. I hope Streling does too with a new layer on
top ..

How about letting the empty string mean : Auto encoding??

xml_parser_create(""); // any decoding! (pass 0 to Expat)

xml_parser_create(); // use default for input&output

xml_parser_create("x"); // Use decoding x for input&output

Looks like the best option to me.

Moriyoshi

-1 for the patch if it doesn't have a default value for the encoding.

We don't want to break BC again.
I respect that. I hope Streling does too with a new layer on
top ..

How about letting the empty string mean : Auto encoding??

xml_parser_create(""); // any decoding! (pass 0 to Expat)

too much magic.

Derick

--
"my other box is your windows PC"

Derick Rethans http://derickrethans.nl/
PHP Magazine - PHP Magazine for Professionals http://php-mag.net/