[RFC] Opt-in JSON Comments and Trailing Commas View as Markdown

Hi

• The RFC keeps two flags, not one JSON_ALLOW_JSONC flag. The JSONC
  specification is a draft, and it makes trailing commas optional. The
  section "Rejected Features" gives all reasons (Tim).

I'm not happy, but the rejected is well-argued :-)

I've given the RFC a full read and don't have any (other) comments. The
RFC is incredibly well-written, thank you!

Just don't forget to add the link to the discussion thread at the header
section: https://news-web.php.net/php.internals/132868

Best regards
Tim Düsterhus

Hello internals,

I want to start the discussion of the RFC "Opt-in JSON Comments and
Trailing Commas":
https://wiki.php.net/rfc/json_comments_trailing_commas

The RFC adds two independent opt-in flags for json_decode() and json_validate():

• JSON_ALLOW_COMMENTS accepts // line comments and /* block comments */.
• JSON_ALLOW_TRAILING_COMMAS accepts one comma after the last item of a
  non-empty array or object.

Strict JSON stays the default. json_encode() does not change.

This RFC follows the pre-RFC thread:
https://news-web.php.net/php.internals/132236

Thank you for the feedback in that thread. The RFC now answers it:

• The RFC does not add JSON5. It compares the two flags with JSON5,
  JSONC and JWCC (Larry, Anton).
• The RFC keeps two flags, not one JSON_ALLOW_JSONC flag. The JSONC
  specification is a draft, and it makes trailing commas optional. The
  section "Rejected Features" gives all reasons (Tim).
• The RFC includes test results and performance measurements.

The implementation is here:
https://github.com/php/php-src/pull/23336

The RFC has two primary votes, one for each flag. Each vote needs a 2/3
majority.

All feedback is welcome.

Otar

I am forced to agree with Tim. This is a very tight RFC, and I have no remaining objections to it. Nicely done!

--Larry Garfield