Hi, I am Zachary DuBois (zacharydubois on the wiki) - been a developer for about 10 years. I am working on a project involving cryptography and noticed PHP is missing some newer libsodium functions that I needed to use. Instead of maintaining my own fork of the extension, I'd like to add in the missing functions (sodium_crypto_kem_*) inside the PHP libsodium extension directly.
I was wondering if adding missing base library functions needs to go through the RFC path as well or if it just needs to be a simple PR on GitHub (I've seen a few extensions get PRs for adding functionality vs going through the RFC path).
Thanks!
-- Zachary J. DuBois
Hi, I am Zachary DuBois (zacharydubois on the wiki) - been a developer for about 10 years. I am working on a project involving cryptography and noticed PHP is missing some newer libsodium functions that I needed to use. Instead of maintaining my own fork of the extension, I'd like to add in the missing functions (
sodium_crypto_kem_*) inside the PHP libsodium extension directly.I was wondering if adding missing base library functions needs to go through the RFC path as well or if it just needs to be a simple PR on GitHub (I've seen a few extensions get PRs for adding functionality vs going through the RFC path).
Thanks!
-- Zachary J. DuBois
me@zacharydubois.me
https://zacharydubois.me
I would say make a PR first; if anyone has any concerns that it might
need design discussion or whatever, you can open up an RFC. You do
have plenty of time since we're in the feature freeze for 8.6, so
you can aim for 8.7.
Hi, I am Zachary DuBois (zacharydubois on the wiki) - been a developer for about 10 years. I am working on a project involving cryptography and noticed PHP is missing some newer libsodium functions that I needed to use. Instead of maintaining my own fork of the extension, I'd like to add in the missing functions (
sodium_crypto_kem_*) inside the PHP libsodium extension directly.I was wondering if adding missing base library functions needs to go through the RFC path as well or if it just needs to be a simple PR on GitHub (I've seen a few extensions get PRs for adding functionality vs going through the RFC path).
Thanks!
-- Zachary J. DuBois
me@zacharydubois.me
https://zacharydubois.me
As I mentioned above, I have finished this work and opened PR 23420. I am new to contributing to PHP so if someone could take a look - that would be awesome.
https://github.com/php/php-src/pull/23420
Thanks!