Hello,
i have small proposal (maybe, it was already discussed here?) - about
ignoring shell invocation lines at the beginning of source file, kind of
#!/usr/local/bin/php
reason is simple - CGI compliance, so that php scripts could work with
any web-server (both via standard CGI and via SAPI modules) without changes.
also, any included script might contain shell invocation too - it's not
good when such line is displayed to user.
implementation for php4 - in zend_language_scanner.l open_file_for_scanning()
read the first line and ignore it if it starts with #!; draft patch is attached
(#if 1/#endif's are to make changes clear). relevant boolean parameter is
"ignore_shell_invocation" (off by default). however, it doesn't work with php5.
--
Best regards,
val mailto:val@vk.kiev.ua
This has already been discussed in the past (I think a couple of years ago)
and it was decided not to make these changes. Frankly, I don't quite
remember the discussion but it might be a good place for you to start.
About the attachment, it didn't come through.
Guys, maybe we can calm down this attachment cleaner a bit. It's becoming
really annoying. It's only in the past few months where it is overly
aggressive.
Andi
At 07:02 PM 10/7/2004 +0300, val khokhlov wrote:
Hello,
i have small proposal (maybe, it was already discussed here?) - aboutignoring shell invocation lines at the beginning of source file, kind of
#!/usr/local/bin/php
reason is simple - CGI compliance, so that php scripts could work with
any web-server (both via standard CGI and via SAPI modules) without changes.
also, any included script might contain shell invocation too - it's not
good when such line is displayed to user.
implementation for php4 - in zend_language_scanner.l
open_file_for_scanning()
read the first line and ignore it if it starts with #!; draft patch is
attached
(#if 1/#endif's are to make changes clear). relevant boolean parameter is
"ignore_shell_invocation" (off by default). however, it doesn't work with
php5.--
Best regards,
val mailto:val@vk.kiev.ua