Hi,
I have gone through the RFC process for a bunch of new functionality for
the SNMP module and wanted to check if there's anything else I need to
do to move this forward, or if it's in the queue and waiting for the
appropriate releases?
Hi
Am 2026-06-03 13:04, schrieb Steven Wilton:
I have gone through the RFC process for a bunch of new functionality
for the SNMP module and wanted to check if there's anything else I need
to do to move this forward, or if it's in the queue and waiting for the
appropriate releases?
As I indicated in your thread about the “SNMP MIB reset function”, SNMP
is pretty obscure, which likely also makes it hard to find reviewers.
Personally I'll not be able to do that meaningfully and don't have the
time to learn SNMP.
That said, I just reached out in Foundation Slack to hopefully find
someone (from the Foundation) to review your PRs.
I suspect it would definitely help if you could clean up the commit
history, rebase the PRs to the latest master and to undraft them for
those you are comfortable with being reviewed. Please make sure to
include a link to your RFC in the commit message and PR description to
make it easy for the reviewer to cross-reference the implementation
against what you proposed in the RFC.
Best regards
Tim Düsterhus
Hi
Am 2026-06-03 13:04, schrieb Steven Wilton:
I have gone through the RFC process for a bunch of new functionality
for the SNMP module and wanted to check if there's anything else I
need to do to move this forward, or if it's in the queue and waiting
for the appropriate releases?As I indicated in your thread about the “SNMP MIB reset function”,
SNMP is pretty obscure, which likely also makes it hard to find
reviewers. Personally I'll not be able to do that meaningfully and
don't have the time to learn SNMP.That said, I just reached out in Foundation Slack to hopefully find
someone (from the Foundation) to review your PRs.I suspect it would definitely help if you could clean up the commit
history, rebase the PRs to the latest master and to undraft them for
those you are comfortable with being reviewed. Please make sure to
include a link to your RFC in the commit message and PR description to
make it easy for the reviewer to cross-reference the implementation
against what you proposed in the RFC.Best regards
Tim Düsterhus
Hi Tim,
Thanks for helping to find a reviewer for this. I had left the combined
PR open with the individual PRs marked as draft, but have reversed this
so the smaller PRs are ready for review. I have also rebased and
cleaned up the commit history, added the PR numbers to the commit
history and added a link to the RFC at the top of the PR. I think this
is everything that should be needed for this to be ready for review.
regards
Steve