[DISCUSS] ext/snmp promote invalid-input warnings to ValueError

2 months ago by Pratik Bhujel — view source — reply

unread

Hi internals,

I opened https://github.com/php/php-src/pull/21319 to promote four ext/snmp
invalid-input warnings to ValueError for invalid input.

Issue: https://github.com/php/php-src/issues/21318

Since this is a BC change I want guidance on whether this direction is
acceptable and whether an RFC is required for this scope.

If the direction is positive I can prepare the RFC next.

Thanks,
Prateek Bhujel

2 months ago by tim@bastelstu.be — view source — reply

unread

Hi Pratik

Welcome to the list and thank you for your interest in contributing to
PHP!

Am 2026-03-03 07:30, schrieb Pratik Bhujel:

Since this is a BC change I want guidance on whether this direction is
acceptable and whether an RFC is required for this scope.

If the direction is positive I can prepare the RFC next.

An RFC to handle this in a generic fashion, without needing to discuss
every extension and function individually was proposed yesterday
(“Exempt input type and value validation from BC Break policy”):
https://news-web.php.net/php.internals/130221.

I recommend to wait for the results of that one (and possibly
participate in the discussion) before proceeding.

See also this email that I just sent:
https://news-web.php.net/php.internals/130235

Best regards
Tim Düsterhus