DatePeriod microsecond support

2 years ago by Marc Bennewitz — view source — reply

unread

Hi,

The DatePeriod class works based on DateTimeInterface but does not take
the microsecond of the date-time instance into account [1].
To fix that I have opened a small PR [2] 2 months ago which got approved
quickly as well but nothing more happened until then.

I'm wring here to kindly ask if this can be merged to be included in 8.4
or if I should do something else?

[1] https://github.com/php/php-src/issues/13773
[2] https://github.com/php/php-src/pull/14581

Thanks,
Marc

2 years ago by Derick Rethans — view source — reply

unread

Hi,

The DatePeriod class works based on DateTimeInterface but does not take the microsecond of the date-time instance into account [1].
To fix that I have opened a small PR [2] 2 months ago which got approved quickly as well but nothing more happened until then.

I'm wring here to kindly ask if this can be merged to be included in 8.4 or if I should do something else?

[1] https://github.com/php/php-src/issues/13773
[2] https://github.com/php/php-src/pull/14581

Thanks,
Marc

I'll get this sorted. IMO this is also a bug fix, but as we are in feature freeze I'll ask thr release managers.

cheers
Derick