[RFC] [Discussion] [VOTE] Rounding Integers as int

Hi

I have opened the vote for the "Rounding Integers as int" RFC:
https://wiki.php.net/rfc/integer-rounding

Please also update the Status within the RFC itself and move it to the
correct section in the RFC overview at: https://wiki.php.net/rfc

Thank you for the reminder. Updated the status and moved in correct
section now.

Best regards
Tim Düsterhus

Hi,

IMHO, the more meaningful cases of the RFC are missing :

round(float, precision: >= 0): int|float // only cast to float for int overflow
ceil(float): int|float // only cast to float for int overflow
floor(float): int|float // only cast to float for int overflow

Calling ceil or floor on integer is meaningless, because it will return the
same value.
The RFC should be "Prefer int as return value when possible".

Le dim. 17 mars 2024 à 15:00, Bob Weinand bobwei9@hotmail.com a écrit :

Hello internals,

I have opened the vote for the "Rounding Integers as int" RFC:
https://wiki.php.net/rfc/integer-rounding

Do to Easter weekend the vote will run for two weeks and two days
until Tue the 2nd of April 2024.

Best regards,

Marc Bennewitz

Hey Marc,

I've voted no; it should be just changed without any force_float
parameter. Just always return int when possible (and the input was int).
If users wish to have the old behaviour, they should just explicitly
cast via (float).

The effective BC break of that would be quite small if some things which
return float today now would return int. I cannot imagine many cases
where this would actually be unwanted. And as said, explicit (float)
casts are always possible.

I also dislike force_float, as it cannot just be added to a function in
any code which shall be backwards compatible to 8.3 and older. It would
just emit Uncaught Error: Unknown named parameter $force_float.

Bob

Hi Bob,

Hello internals,

I have opened the vote for the "Rounding Integers as int" RFC:
https://wiki.php.net/rfc/integer-rounding

Do to Easter weekend the vote will run for two weeks and two days
until Tue the 2nd of April 2024.

Best regards,

Marc Bennewitz

Hey Marc,

I've voted no; it should be just changed without any force_float
parameter. Just always return int when possible (and the input was int).
If users wish to have the old behaviour, they should just explicitly
cast via (float).

The effective BC break of that would be quite small if some things
which return float today now would return int. I cannot imagine many
cases where this would actually be unwanted. And as said, explicit
(float) casts are always possible.

I also dislike force_float, as it cannot just be added to a function
in any code which shall be backwards compatible to 8.3 and older. It
would just emit Uncaught Error: Unknown named parameter $force_float.

Changing the return type from float to int is a non trivial quite hard
to find behavior change.

Imaging code like this:

$x = 800;
$y = 800;
round($x/$y) === 1.0;

This will return false instead of true especially because we teach users
to use strict comparison.
Such behavior change should be done in a major version.

With the additional parameter it's possible to opt-in into the new
behavior already in 8.4 while in PHP 9.0 the default behavior will
change but previously opted in code does not need to get touched again.

Just changing the behavior means waiting for PHP 9.0 without a way to
opt-in in 8.4 already. If you are not interested in opting in in 8.4
already you can just ignore the additional argument as this will be the
default in 9.0.

To mimic the previous behavior in a fully BC way it's as simple as
explicitly casting the value to float.

Bob

Regards,
Marc