base64_encode without padding

Link to the PR https://github.com/php/php-src/pull/13698

Hi

Use case: for ARGON2 password hashing
see https://github.com/php/php-src/pull/13635

It may seems ugly to add and remove th padding char

Is a RFC needed for such a minor feature ?

Previous related discussion: https://externals.io/message/119243#119243.
My remark about using a cache-timing safe encoder might be relevant for
the argon2 usecase.

Best regards
Tim Düstzerhus

I think padding should be optional (on by default to keep BC)

Of course in user land, simple to write

  $enc = trim(base64_encode('foo'), '=');

This proposal allow to simply use

  $enc = base64_encode('foo', PHP_BASE64_NO_PADDING);

And also expose it for extension as

  PHPAPI extern zend_string *php_base64_encode_ex
    (const unsigned char *, size_t, zend_long flags);

Use case: for ARGON2 password hashing
see https://github.com/php/php-src/pull/13635

It may seems ugly to add and remove th padding char

Is a RFC needed for such a minor feature ?

Remi

Great addition! Only I would strongly prefer a boolean argument over a
flag. Especially now that we have named arguments, adding a bunch of
optional boolean arguments to the signature does not lead to unreadable
code anymore. In fact, I think it yields code that is easier to read.

Regards,
Dik

I think padding should be optional (on by default to keep BC)

Of course in user land, simple to write

$enc = trim(base64_encode('foo'), '=');

This proposal allow to simply use

$enc = base64_encode('foo', PHP_BASE64_NO_PADDING);

Please add PHP_BASE64_URL flag also.
BASE64 URL encoding (URL safe Base64 encoding) is used everywhere.
i.e. str_replace(['+','/','='], ['-','_',''], base64_encode($str);

https://base64.guru/standards/base64url

Decoding should be extended.
i.e. base64_decode($encoded, PHP_BASE64_URL)

Adding PHP_BASE64_STRICT flag may be reasonable, that requires specific
encoding strictly for decoding.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

And also expose it for extension as

PHPAPI extern zend_string *php_base64_encode_ex
(const unsigned char *, size_t, zend_long flags);

Use case: for ARGON2 password hashing
see https://github.com/php/php-src/pull/13635

It may seems ugly to add and remove th padding char

Is a RFC needed for such a minor feature ?

Remi

Le 13/03/2024 à 17:06, Remi Collet a écrit :

  PHPAPI extern zend_string *php_base64_encode_ex
    (const unsigned char *, size_t, zend_long flags);

This is done in master

No change in user-land
and no plan from me.

Remi