Renaming on of the XML opaque objects for consistency

5 years ago by G. P. B. — view source — reply

unread

Greetings internals,

I know this is literally hours before the GA tag, but I just realized
that when introducing opaque objects during the resource to object
conversion the XMLWriter and XMLParser extensions don't use the same casing
as the classes are named XmlParser and XMLWriter

Should we rename one of them for consistency just before GA is tagged or
let it be?

Best,

George P. Banyard

5 years ago by Claude Pache — view source — reply

unread

Since class names are case-insensitive, and since XmlParser is new as of PHP 8.0, I guess that there is not much problems in correcting the canonical casing of XmlParser into XMLParser? Count it as a last-minute bugfix.

—Claude

5 years ago by tyson andre — view source — reply

unread

I know this is literally hours before the GA tag, but I just realized
that when introducing opaque objects during the resource to object
conversion the XMLWriter and XMLParser extensions don't use the same casing
as the classes are named XmlParser and XMLWriter

Should we rename one of them for consistency just before GA is tagged or
let it be?

I'd be in favor of XMLParser to match XMLReader, XMLWriter, and SimpleXMLElement/SimpleXMLIterator.

Cheers,
-- Tyson