Hello,
Today I was finishing writing the tidy docs and I've noted that the
functions $tidy->repairString() and $tidy->repairFile() simply don't work!
And I think these functions should be removed. I'll explain:
non-OO way:
<?
echo tidy_repair_string($html);
?>
OO way:
<?
$tidy = new tidy;
var_dump($tidy->repairString($html));
echo $html;
?>
The non-OO way is very simple, you give it a broken HTML and it returns a
repaired HTML string. And in OO? It returns nothing! And why should you want
that function in OO? tidy_repair_string() is a one-time use only function.
Even if it exists in OO, you can't do anything with it (even if it
worked...)
Can you delete those funtions, please (isn't really the functions, just the
OO mapping)?
Thanks,
Nuno
Nuno Lopes wrote:
Hello,
Today I was finishing writing the tidy docs and I've noted that the
functions $tidy->repairString() and $tidy->repairFile() simply don't work!
And I think these functions should be removed. I'll explain:non-OO way:
<?
echo tidy_repair_string($html);
?>OO way:
<?
$tidy = new tidy;
var_dump($tidy->repairString($html));
echo $html;?>
The non-OO way is very simple, you give it a broken HTML and it returns a
repaired HTML string. And in OO? It returns nothing! And why should you want
that function in OO? tidy_repair_string() is a one-time use only function.
Even if it exists in OO, you can't do anything with it (even if it
worked...)Can you delete those funtions, please (isn't really the functions, just the
OO mapping)?Thanks,
Nuno
Maybe John has to make this methods static and they will work just like the
functions.
Regards,
Andrey
Maybe John has to make this methods static and they will work just like
the
functions.Regards,
Andrey
Thats a good idea! But as we already have the non-OO function, I don't know
if it worth to create the static methods.
Nuno
Quoting Nuno Lopes nlopess@php.net:
Maybe John has to make this methods static and they will work just like
the
functions.Regards,
AndreyThats a good idea! But as we already have the non-OO function, I don't know
if it worth to create the static methods.
Nuno
For the purists out there :)
andrey