Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.
Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
Regards,
Nikita
+1
Cheers
Joe
Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?Regards,
Nikita
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
No objections from my side, but note that there is already separate
karma for Zend/tests.
--
Christoph M. Becker
Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
No objections here - the separation is fairly meaningless nowadays.
Zeev
Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.
Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
No objections here - the separation is fairly meaningless nowadays.
On second reading, do you mean to merge the Zend/TSRM into one, or so away with both altogether? I initially read it as the former but based on the reasoning I think you probably meant the latter..? Personally, given the complexity I think this level of granularity makes sense - do we really have that many folks that should have direct access there?
Zeev
Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than useful at this point.
Most changes from newer contributors are approved on GitHub first, and we
often have to grant some form of Zend karma for tests if nothing else
anyway.
Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
No objections here - the separation is fairly meaningless nowadays.
On second reading, do you mean to merge the Zend/TSRM into one, or so away
with both altogether? I initially read it as the former but based on the
reasoning I think you probably meant the latter..? Personally, given the
complexity I think this level of granularity makes sense - do we really
have that many folks that should have direct access there?Zeev
Zend/TSRM already have shared karma, I'm suggesting to merge it into
php-src karma. Complexity is pretty meaningless here, as changes need to be
reviewed anyway. Zend/ isn't different from other code in that respect. We
also have plenty of other complex code outside of Zend, such as ext/opcache.
Nikita
Hi!
Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?
Makes sense to merge Zend karma into php-src karma (I imagine smaller
karma sets, e.g. for tests or specific ext only, remain?).
--
Stas Malyshev
smalyshev@gmail.com
Any objections to dropping this and have a single php-src karma for the
whole tree (with the exception of php_version.h, which is used to prevent
bad merges)?No objections from me. This divide dates back to /long/ before the RFC
process. We've gotten much better about not "cowboy" committing things
without discussion.
-Sara