[RFC] Implement strrstr counterpart to strstr for consistency

7 years ago by G. P. B. — view source — reply

unread

Hello Internals;

I've written an RFC to get feedback about adding a counterpart to strstr to
make it more in line with the strpos family of functions which can be found
here: https://wiki.php.net/rfc/implement-strrstr-for-consistency

I've been mulling over this for quite some time as the PR [1] was created
in April as there are quite some cons compared to pros which are detailed
in the RFC.
I'm not sure myself if this is a good idea but as feature freeze is coming
close it seems to be a good time to get feedback on this.

If nothing dramatic comes up or if a majority thinks this is a bad idea
I'll withdraw it, otherwise expect this to be put to a vote in two weeks
time.

Best regards

George P. Banyard

[1] https://github.com/php/php-src/pull/4064

7 years ago by Marco Pivetta — view source — reply

unread

IS it possible to have something with a sensible name? These read like a
diesel engine failing to start up...

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

Hello Internals;

I've written an RFC to get feedback about adding a counterpart to strstr to
make it more in line with the strpos family of functions which can be found
here: https://wiki.php.net/rfc/implement-strrstr-for-consistency

I've been mulling over this for quite some time as the PR [1] was created
in April as there are quite some cons compared to pros which are detailed
in the RFC.
I'm not sure myself if this is a good idea but as feature freeze is coming
close it seems to be a good time to get feedback on this.

If nothing dramatic comes up or if a majority thinks this is a bad idea
I'll withdraw it, otherwise expect this to be put to a vote in two weeks
time.

Best regards

George P. Banyard

[1] https://github.com/php/php-src/pull/4064

7 years ago by G. P. B. — view source — reply

unread

IS it possible to have something with a sensible name? These read like a
diesel engine failing to start up...

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

Oh I totally agree on that but I have no idea how to name it otherwise, I'm
open for suggestions because well I find this rather suboptimal myself.

George P. Banyard