# PHP_OS_FAMILY and macOS - Thread: https://externals.io/message/99501 - Original archive: https://news-web.php.net/php.internals/99501 - Started by Sebastian Bergmann on 2017-06-13T05:20:00+00:00 - Messages: 11 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #99501 — Sebastian Bergmann — 2017-06-13T05:20:00+00:00 URL: https://externals.io/message/99501#99501 Thinking about https://github.com/sebastianbergmann/environment/issues/21 it just occured to me that `PHP_OS_FAMILY` currently contains "OSX". Apple renamed (last year?) their "OS X" to "macOS". Should `PHP_OS_FAMILY` not contain "macOS" then? Now would be the time to make that change without breaking BC. --- ## #99502 — Niklas Keller — 2017-06-13T06:00:52+00:00 URL: https://externals.io/message/99501#99502 · In reply to: #99501 2017-06-13 7:20 GMT+02:00 Sebastian Bergmann : > Thinking about https://github.com/sebastianbergmann/environment/issues/21 > it just occured to me that `PHP_OS_FAMILY` currently contains "OSX". > > Apple renamed (last year?) their "OS X" to "macOS". Should `PHP_OS_FAMILY` > not contain "macOS" then? Now would be the time to make that change > without breaking BC. > Apply changes it every few years, maybe we should just call it "Apple"? :D Regards, Niklas --- ## #99504 — Kalle Sommer Nielsen — 2017-06-13T12:21:12+00:00 URL: https://externals.io/message/99501#99504 · In reply to: #99502 Hi 2017-06-13 8:00 GMT+02:00 Niklas Keller : > Apply changes it every few years, maybe we should just call it "Apple"? :D I don't think that is all that bad an idea tbh, or simply "Mac" -- regards, Kalle Sommer Nielsen kalle@php.net --- ## #99505 — Derick Rethans — 2017-06-13T12:40:08+00:00 URL: https://externals.io/message/99501#99505 · In reply to: #99501 > Thinking about https://github.com/sebastianbergmann/environment/issues/21 > it just occured to me that `PHP_OS_FAMILY` currently contains "OSX". > > Apple renamed (last year?) their "OS X" to "macOS". Should `PHP_OS_FAMILY` > not contain "macOS" then? Now would be the time to make that change > without breaking BC. Changing it surely means breaking BC? I believe we should continue to use OSX. cheers, Derick --- ## #99506 — Sebastian Bergmann — 2017-06-13T12:42:36+00:00 URL: https://externals.io/message/99501#99506 · In reply to: #99505 Am 13.06.2017 um 14:40 schrieb Derick Rethans: > Changing it surely means breaking BC? I believe we should continue to > use OSX. `PHP_OS_FAMILY` is new in PHP 7.2, which is not final yet. --- ## #99507 — Derick Rethans — 2017-06-13T12:45:24+00:00 URL: https://externals.io/message/99501#99507 · In reply to: #99506 > Am 13.06.2017 um 14:40 schrieb Derick Rethans: > > […] > > `PHP_OS_FAMILY` is new in PHP 7.2, which is not final yet. In that case, I agree with "macOS" as you suggested. cheers, Derick --- ## #99508 — Zeev Suraski — 2017-06-13T13:00:03+00:00 URL: https://externals.io/message/99501#99508 · In reply to: #99504 > -----Original Message----- > From: kalle.php@gmail.com [mailto:kalle.php@gmail.com] On Behalf Of Kalle > Sommer Nielsen > Sent: Tuesday, June 13, 2017 3:21 PM > To: Niklas Keller > Cc: PHP Internals > Subject: Re: [PHP-DEV] `PHP_OS_FAMILY` and macOS > > Hi > > 2017-06-13 8:00 GMT+02:00 Niklas Keller : > > […] > > I don't think that is all that bad an idea tbh, or simply "Mac" Yep, Mac sounds like a fairly future-proof choice, and is also consistent with the capitalization of other options. Zeev --- ## #99509 — Sebastian Bergmann — 2017-06-13T13:47:49+00:00 URL: https://externals.io/message/99501#99509 · In reply to: #99508 Am 13.06.2017 um 15:00 schrieb Zeev Suraski: > Yep, Mac sounds like a fairly future-proof choice, and is also consistent with the capitalization of other options. Implemented in http://git.php.net/?p=php-src.git;a=commitdiff;h=362d2e42a02fe018a7d1261a53ff59b73fed91f6 --- ## #99513 — Davey Shafik — 2017-06-13T19:35:02+00:00 URL: https://externals.io/message/99501#99513 · In reply to: #99509 Given that iPad (and iPhone) both run iOS which is based on Darwin, and Apple just relaxed the rules on running interpreted code, and we are already seeing IDEs spring up for the device, we should use "Darwin", rather than "Mac". This also encompasses other distros like PureDarwin. - Davey On Tue, Jun 13, 2017 at 6:47 AM, Sebastian Bergmann wrote: > Am 13.06.2017 um 15:00 schrieb Zeev Suraski: > > […] > consistent with the capitalization of other options. > > Implemented in > http://git.php.net/?p=php-src.git;a=commitdiff;h= > 362d2e42a02fe018a7d1261a53ff59b73fed91f6 --- ## #99514 — Marc Bennewitz — 2017-06-13T20:20:42+00:00 URL: https://externals.io/message/99501#99514 · In reply to: #99513 Am 13.06.2017 um 21:35 schrieb Davey Shafik: > Given that iPad (and iPhone) both run iOS which is based on Darwin, and > Apple just relaxed the rules on running interpreted code, and we are > already seeing IDEs spring up for the device, we should use "Darwin", > rather than "Mac". This also encompasses other distros like PureDarwin. nice catch +1 from me > > - Davey > > > > On Tue, Jun 13, 2017 at 6:47 AM, Sebastian Bergmann > wrote: > > > […] --- ## #99516 — Kalle Sommer Nielsen — 2017-06-14T01:31:09+00:00 URL: https://externals.io/message/99501#99516 · In reply to: #99513 Hi 2017-06-13 21:35 GMT+02:00 Davey Shafik : > Given that iPad (and iPhone) both run iOS which is based on Darwin, and > Apple just relaxed the rules on running interpreted code, and we are > already seeing IDEs spring up for the device, we should use "Darwin", > rather than "Mac". This also encompasses other distros like PureDarwin. I agree, it makes a lot more sense than "Mac", I changed this to "Darwin": http://git.php.net/?p=php-src.git;a=commit;h=a251d9b2c11c2ab53b0214d728c40d70cd06567c -- regards, Kalle Sommer Nielsen kalle@php.net