# Fixing return value memory leaks upon exceptions in opcode operand freeing

- Thread: https://externals.io/message/97244
- Original archive: https://news-web.php.net/php.internals/97244
- Started by Dmitry Stogov on 2016-12-02T08:53:46+00:00
- Messages: 1
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #97244 — Dmitry Stogov — 2016-12-02T08:53:46+00:00

URL: https://externals.io/message/97244#97244

>
> 
> > […]

This is a critical problem.
You broke quite complex part of the code.
I'm going to revert the patch, and then review/rework/recommit it part by part.

Thanks. Dmitry.

> > […]
>
> > […]
>
>
> I suppose, Nikita told not to merge the whole patch into 7.1, because it's too risky. (I'm completely agree).
>
> But unrelated minor fixes, just have to be done separately.
>
> I'm currently run "make test TESTS=-m Zend" (this was your job before committing), and depending on found bugs (I already see few failures) we might have to revert the whole patch, including these right fixes.
>
>
> Thanks. Dmitry.
>
>
> > […]